linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helmut Schaa <helmut.schaa@googlemail.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, yi.zhu@intel.com,
	reinette.chatre@intel.com, ipw2100-devel@lists.sourceforge.net
Subject: [PATCH] ipw2200: increase scan timeout
Date: Tue, 25 Nov 2008 18:09:54 +0100	[thread overview]
Message-ID: <200811251809.55461.helmut.schaa@gmail.com> (raw)

The current scan timeout is set to 5 seconds. If the timeout is hit because
the firmware did not respond yet, the adapter gets restarted, which results
in a disassociation.

However, in an environment with lots of access points the scan sometimes takes
longer than 5 seconds. This patch simply increases the timeout to 10 seconds.

Signed-off-by: helmut.schaa@googlemail.com
---

I was able to reproduce the issue fairly reliable with a 2915 adapter by 
periodically triggering scans while associated.

I have no idea in which situations the scan takes longer than 5 seconds to
complete but maybe it might even take longer than 10 seconds. Has anybody from
Intel insight into the firmware scan code?

diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index c73173a..a776da3 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -2304,7 +2304,7 @@ static void ipw_bg_adapter_restart(struct work_struct *work)
 	mutex_unlock(&priv->mutex);
 }
 
-#define IPW_SCAN_CHECK_WATCHDOG (5 * HZ)
+#define IPW_SCAN_CHECK_WATCHDOG (10 * HZ)
 
 static void ipw_scan_check(void *data)
 {

             reply	other threads:[~2008-11-25 17:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 17:09 Helmut Schaa [this message]
2008-11-25 18:32 ` [PATCH] ipw2200: increase scan timeout reinette chatre
2008-11-25 22:06   ` [Ipw2100-devel] " Cahill, Ben M
2008-11-26  8:21   ` Helmut Schaa
2008-11-26 16:28   ` Helmut Schaa
2008-11-25 19:35 ` Dan Williams
2008-11-26  8:19   ` Helmut Schaa
2008-11-25 22:17 ` [Ipw2100-devel] " Harald Braumann
2008-11-26  8:13   ` Helmut Schaa
2008-11-26  7:06 ` Holger Schurig
2008-11-26  7:24   ` Kalle Valo
2008-11-26  8:04     ` Zhu Yi
2008-11-26 16:19       ` Dan Williams
2008-11-26  8:09   ` Helmut Schaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811251809.55461.helmut.schaa@gmail.com \
    --to=helmut.schaa@googlemail.com \
    --cc=ipw2100-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).