From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vivek Natarajan <Vivek.Natarajan@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Kalle Valo <kalle.valo@nokia.com>
Subject: Re: [RFC] mac80211: Enhancements to dynamic power save.
Date: Mon, 1 Dec 2008 15:53:32 -0800 [thread overview]
Message-ID: <20081201235331.GU5992@tesla> (raw)
In-Reply-To: <1228132431.3478.21.camel@johannes.berg>
On Mon, Dec 01, 2008 at 03:53:51AM -0800, Johannes Berg wrote:
> On Mon, 2008-12-01 at 17:17 -0800, Vivek Natarajan wrote:
> > This patch is based on Kalle's initial RFC patches on dynamic power save.
> > Since ath9k/ath5k,stlc45xx and b43 need the driver to send the null
> > frame, it is appropriate to do it from mac80211.
> > This patch enables mac80211 to send a null frame and also to
> > check for tim in the beacon if power save is enabled.
>
> Nice! Looks pretty much good to me, but could use some documentation
> (Kalle will hopefully add some too). For instance, a casual observer
> might wonder how the hardware can be saving power when the host software
> has to parse beacons -- obviously things will only fall into place once
> we support beacon miss offload.
BTW does broadcom hw support beacon miss stuff? We need to consider
carefully how we add beacon miss support because if we want to rely on
it *and* also disable say the beacon filter we will be missing out on
DFS channel switch announcements and HT channel badwidth changes from
the AP.
Luis
next prev parent reply other threads:[~2008-12-01 23:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 1:17 [RFC] mac80211: Enhancements to dynamic power save Vivek Natarajan
2008-12-01 11:53 ` Johannes Berg
2008-12-01 15:08 ` Vivek Natarajan
2008-12-01 15:55 ` Kalle Valo
2008-12-01 15:52 ` Kalle Valo
2008-12-01 23:53 ` Luis R. Rodriguez [this message]
2008-12-01 12:05 ` Johannes Berg
2008-12-01 16:17 ` Kalle Valo
2008-12-01 17:00 ` Tomas Winkler
2008-12-02 12:58 ` Vivek Natarajan
2008-12-02 14:29 ` Tomas Winkler
2008-12-01 15:42 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2008-12-23 4:44 Vivek Natarajan
2008-12-22 17:12 ` Johannes Berg
2008-12-23 12:50 ` Vivek Natarajan
2008-12-23 20:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201235331.GU5992@tesla \
--to=lrodriguez@atheros.com \
--cc=Vivek.Natarajan@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).