From: Kalle Valo <kalle.valo@nokia.com>
To: linux-wireless@vger.kernel.org
Subject: [RFC PATCH v4 0/5] mac80211 dynamic power save
Date: Tue, 02 Dec 2008 22:03:51 +0200 [thread overview]
Message-ID: <20081202200219.5507.83250.stgit@tikku> (raw)
Here is v4 of my dynamic powersave patches. I have tested them only
with stlc45xx on Nokia N810. I'm also working with iwl3945 and iwlagn
patches based on these patches, but I haven't finished them yet.
These are RFC patches, not yet to be applied.
Patch 3 contains a new flag IEEE80211_HW_NO_DYNAMIC_PS. So all drivers
which firmware doesn't support dynamic power save should use this flag
to enable the feature in mac80211. This is a separate patch just for
easier review. If it's ok, I'll fold it to patch 2.
Patch 4 moves the dynamic_ps_timeout to ieee80211_conf struct. That
way the drivers which have dynamic power save support in firmware can
use the same timeout provided by user space. If this ok I'll fold this
to patch 2.
Patch 5 contains internal interface mac80211 to enable and disable
queues. The original idea and design is from Johannes Berg, I just did
the implementation based on those. All the bugs are mine, of course.
changes in v4:
o add check for station interface to siwpower()
o call hw_config() also for dynamic timeout changes
o add dynamic_ prefix to workqueues
o test for IEEE80211_HW_NO_DYNAMIC_PS in siwpower()
o wrote documentation for IEEE80211_HW_NO_DYNAMIC_PS
o wrote documentation for conf->dynamic_ps_timeout
changes in v3:
o add a hw flag to notify that driver doesn't support dynamic power save and
which will enable mac80211 implementation
o delete dynamic_ps_timer and cancel ps_enable_work during
association, hopefully it's race free now
o provide timeout value to the drivers, for example iwlwifi should use
it (example patch under works)
o fix a bad bug in testing IEEE80211_STA_ASSOCIATED flag with && operator
TODO:
o test with iwlwifi (only in-tree driver using IEEE80211_CONF_PS)
Power save related features which I'll implement later:
o disable power save when software scanning
o beacon period (wakeup period) to the drivers, can be set from user
space but otherwise is bss's DTIM value
---
Kalle Valo (5):
mac80211: track master queue status
mac80211: move dynamic_ps_timeout to hw.conf
mac80211: add IEEE80211_HW_NO_DYNAMIC_PS flag
mac80211: implement dynamic power save
mac80211: enable IEEE80211_CONF_PS only when associated
include/net/mac80211.h | 10 +++++++
net/mac80211/ieee80211_i.h | 22 +++++++++++++++-
net/mac80211/main.c | 9 +++++++
net/mac80211/mlme.c | 60 +++++++++++++++++++++++++++++++++++++++++++-
net/mac80211/tx.c | 13 ++++++++++
net/mac80211/util.c | 60 ++++++++++++++++++++++++++++++++++++++++----
net/mac80211/wext.c | 46 ++++++++++++++++++++++++++++------
7 files changed, 203 insertions(+), 17 deletions(-)
next reply other threads:[~2008-12-02 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 20:03 Kalle Valo [this message]
2008-12-02 20:03 ` [RFC PATCH v4 1/5] mac80211: enable IEEE80211_CONF_PS only when associated Kalle Valo
2008-12-04 17:27 ` Johannes Berg
2008-12-05 5:47 ` Kalle Valo
2008-12-05 9:40 ` Johannes Berg
2008-12-02 20:04 ` [RFC PATCH v4 2/5] mac80211: implement dynamic power save Kalle Valo
2008-12-02 20:04 ` [RFC PATCH v4 3/5] mac80211: add IEEE80211_HW_NO_DYNAMIC_PS flag Kalle Valo
2008-12-02 20:04 ` [RFC PATCH v4 4/5] mac80211: move dynamic_ps_timeout to hw.conf Kalle Valo
2008-12-02 20:04 ` [RFC PATCH v4 5/5] mac80211: track master queue status Kalle Valo
2008-12-04 17:34 ` Johannes Berg
2008-12-05 5:51 ` Kalle Valo
2008-12-05 9:41 ` Johannes Berg
2008-12-05 9:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081202200219.5507.83250.stgit@tikku \
--to=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).