From: Jouni Malinen <j@w1.fi>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Senthil Balasubramanian <senthilkumar@atheros.com>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Luis Rodriguez <lrodriguez@atheros.com>
Subject: Re: [PATCH] wireless: Incorrect LEAP authentication algorithm identifier.
Date: Thu, 4 Dec 2008 18:20:03 +0200 [thread overview]
Message-ID: <20081204162003.GA997@jm.kir.nu> (raw)
In-Reply-To: <20081204152224.GA4989@tuxdriver.com>
On Thu, Dec 04, 2008 at 10:22:25AM -0500, John W. Linville wrote:
> On Thu, Dec 04, 2008 at 08:38:13PM +0530, Senthil Balasubramanian wrote:
> > -#define WLAN_AUTH_LEAP 2
> > +#define WLAN_AUTH_LEAP 128
> What is the regression? What problem does this cause?
The current code fails to authenticate when the AP (most likely Cisco
AP) is configured for "Network EAP" mode. The old code (before the
cleanup) allowed the authentication to be completed successfully.
> AFAICT this value is only used internally, so it shouldn't matter
> what the actual value is.
Nope. WLAN_AUTH_* are the values used in Authentication frames
(Authentication Algorithm field). See ieee80211_send_auth() in
net/mac80211/mlme.c. The ifsta->auth_alg must have a value that matches
with the algorithm identifier in the frame and in the case of LEAP
("Network EAP"), this value is 128, not 2.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2008-12-04 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 15:08 [PATCH] wireless: Incorrect LEAP authentication algorithm identifier Senthil Balasubramanian
2008-12-04 15:22 ` John W. Linville
2008-12-04 16:20 ` Jouni Malinen [this message]
2008-12-04 18:33 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204162003.GA997@jm.kir.nu \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=senthilkumar@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).