Re: [PATCH 1/2] mac80211: add suspend/resume callbacks

["Bob Copeland" <me@bobcopeland.com>]

On Tue, 09 Dec 2008 16:59:06 +0100, Johannes Berg wrote
> > Is this what you had in mind? (now on top of your cfg80211 patch, btw
> > it called ->suspend() in the resume hook)
> 
> Can you adopt that patch too?

Yeah, I already have it in my tree, I just didn't repost it because my 
webmail sucks.

> > +	/* remove all interfaces */
> > +	list_for_each_entry(sdata, &local->interfaces, list) {
> > +
> > +		if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
> > +		    sdata->vif.type == NL80211_IFTYPE_MONITOR &&
> > +		    netif_running(sdata->dev)) {
> 
> But shouldn't that be != _AP_VLAN && != _MONITOR && running?

Oops, of course it should; that if() started life as continue.  
But that would just mean a missed call to remove_interface()... 
in the driver, which for ath5k just clears the mac, so I don't 
know why it would affect the running state of the interface.

> I'd just add those to ieee80211_i.h, and I don't think you really need
> to protect them with #ifdef CONFIG_PM

Will do, thanks for the review.

-- 
Bob Copeland %% www.bobcopeland.com