From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de,
hmh@hmh.eng.br
Subject: Re: [RFC] b43: rework rfkill code
Date: Wed, 17 Dec 2008 10:48:01 -0500 [thread overview]
Message-ID: <20081217154800.GA12679@tuxdriver.com> (raw)
In-Reply-To: <4941E863.50703@lwfinger.net>
On Thu, Dec 11, 2008 at 10:28:19PM -0600, Larry Finger wrote:
> Matthew Garrett wrote:
> > I've reworked the rfkill code in b43. This ought to be more consistent
> > with the other drivers and it seems to work on the machines I've tested
> > it on here, but it'd be good to get some feedback.
<snip>
> > How does this look to people?
>
> All this discussion about hard vs soft rfkill makes my head hurt and I have
> stopped reading those posts.
>
> Correction to my earlier post. If the system is booted with the RF switch off,
> the LED is on, whereas it should be off. The original code works correctly.
Based on the above, I'm dropping this patch. Please submit a
non-regressing version! :-)
John
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
prev parent reply other threads:[~2008-12-17 16:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 15:09 [RFC] b43: rework rfkill code Matthew Garrett
2008-12-10 15:29 ` Johannes Berg
2008-12-10 16:15 ` Ivo van Doorn
2008-12-10 16:51 ` Marcel Holtmann
2008-12-10 17:18 ` Johannes Berg
2008-12-10 17:23 ` Johannes Berg
2008-12-10 17:28 ` Johannes Berg
2008-12-10 21:33 ` Henrique de Moraes Holschuh
2008-12-10 21:42 ` Michael Buesch
2008-12-10 17:31 ` Michael Buesch
2008-12-10 17:37 ` Johannes Berg
2008-12-10 17:51 ` Matthew Garrett
2008-12-10 18:04 ` Michael Buesch
2008-12-10 18:05 ` Johannes Berg
2008-12-10 18:09 ` Matthew Garrett
2008-12-10 18:29 ` Dan Williams
2008-12-10 18:33 ` Johannes Berg
2008-12-10 18:59 ` Dan Williams
2008-12-10 20:07 ` Michael Buesch
2009-03-29 18:19 ` Johannes Berg
2008-12-11 0:32 ` Julian Calaby
2008-12-11 1:27 ` Michael Buesch
2008-12-11 13:28 ` Kalle Valo
2008-12-10 15:48 ` Michael Buesch
2008-12-10 16:12 ` Matthew Garrett
2008-12-11 16:55 ` Larry Finger
2008-12-12 4:28 ` Larry Finger
2008-12-17 15:48 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217154800.GA12679@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=hmh@hmh.eng.br \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).