From: "Bob Copeland" <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Stefanik Gábor " <netrolller.3d@gmail.com>,
"Dan Williams" <dcbw@redhat.com>,
linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: set mac address in add_interface
Date: Fri, 19 Dec 2008 10:15:16 -0500 [thread overview]
Message-ID: <20081219151036.M48373@bobcopeland.com> (raw)
In-Reply-To: <1229439670.4471.41.camel@johannes.berg>
On Tue, 16 Dec 2008 16:01:09 +0100, Johannes Berg wrote
> > The ath5k rx filter for unicast frames requires mac addresses to match in
> > order to accept or ack frames. However, in monitor mode, mac80211 will
> > never call add_interface(). Instead, it should configure the filter to
> > put the card in promiscuous mode which then should enable all packets
> > to be passed back to the host.
>
> FWIW, this is as designed, if you need to have ACKs then you need to
> bring up a monitor as well as a regular interface. Stefanik, please do
> that and report whether it works.
So in that case, ath5k definitely should not upload a mac until a normal
interface is brought up, i.e. we should keep the current functionality?
It's interesting that b43 works without a regular interface, by my reading of
its code the mac is also loaded and cleared at add/remove interface time.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-12-19 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 4:40 [PATCH] ath5k: set mac address in add_interface Bob Copeland
2008-11-21 19:49 ` Maxim Levitsky
2008-11-21 20:01 ` [ath5k-devel] " Bob Copeland
2008-11-21 20:53 ` Maxim Levitsky
2008-11-21 21:45 ` Maxim Levitsky
2008-11-21 23:15 ` Bob Copeland
2008-11-22 13:25 ` Maxim Levitsky
2008-12-15 15:47 ` Stefanik Gábor
2008-12-15 16:04 ` Dan Williams
2008-12-15 16:12 ` Stefanik Gábor
2008-12-15 16:22 ` Dan Williams
2008-12-15 17:16 ` [ath5k-devel] " Bob Copeland
2008-12-16 14:58 ` Bob Copeland
2008-12-16 15:01 ` Johannes Berg
2008-12-19 15:15 ` Bob Copeland [this message]
2008-12-20 9:46 ` Johannes Berg
2008-12-16 15:42 ` Stefanik Gábor
[not found] ` <20081215161435.M87237@bobcopeland.com>
2008-12-15 16:30 ` Stefanik Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219151036.M48373@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).