From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, bcm43xx-dev@lists.berlios.de,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Fix some MAC locking
Date: Fri, 19 Dec 2008 16:40:07 +0100 [thread overview]
Message-ID: <200812191640.07863.mb@bu3sch.de> (raw)
In-Reply-To: <494BC02B.4000906@lwfinger.net>
On Friday 19 December 2008 16:39:23 Larry Finger wrote:
> Michael Buesch wrote:
> > This fixes some locking w.r.t. the lower MAC (firmware).
> > It also removes a lot of ancient IRQ-locking that's not needed anymore.
> > We simply suspend the MAC. That's easier and causes less trouble.
>
> When booting with this patch and the RFKILL switch off, I got these b43dbg messages:
>
> kernel: b43-phy0 debug: PHY/RADIO register access with enabled MAC.
> kernel: Pid: 7, comm: events/0 Not tainted 2.6.28-rc8-wl #55
> kernel: Call Trace:
> kernel: [<ffffffffa02d6b15>] b43_phy_read+0x33/0x46 [b43]
> kernel: [<ffffffffa02d8350>] b43_gphy_op_software_rfkill+0xde/0x131 [b43]
> kernel: [<ffffffffa02d66d8>] b43_software_rfkill+0x20/0x2d [b43]
Thanks.
I guess suspending MAC before killing RF is a good thing anyway. I'll do a patch.
--
Greetings, Michael.
prev parent reply other threads:[~2008-12-19 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 21:13 [PATCH] b43: Fix some MAC locking Michael Buesch
2008-12-19 15:39 ` Larry Finger
2008-12-19 15:40 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812191640.07863.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).