From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vivek Natarajan <vivek.natraj@gmail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Enable dynamic power save in ath9k.
Date: Mon, 29 Dec 2008 13:23:54 +0100 [thread overview]
Message-ID: <200812291323.54588.mb@bu3sch.de> (raw)
In-Reply-To: <1230552660.3116.33.camel@johannes>
On Monday 29 December 2008 13:11:00 Johannes Berg wrote:
> On Mon, 2008-12-29 at 15:53 -0800, Vivek Natarajan wrote:
>
> > +#define ATH9K_PS_WAKEUP(sc) \
> > + do { \
> > + if (!atomic_read(&sc->ps_usecount) && \
> > + (ah->ah_powerMode != ATH9K_PM_AWAKE)) { \
> > + ah->ah_restoreMode = ah->ah_powerMode; \
> > + ath9k_hw_setpower(sc->sc_ah, ATH9K_PM_AWAKE); \
> > + } \
> > + atomic_inc(&sc->ps_usecount); \
> > + } while (0);
> > +
> > +#define ATH9K_PS_RESTORE(sc) \
> > + do { \
> > + if (atomic_dec_and_test(&sc->ps_usecount) && \
> > + (sc->hw->conf.flags & IEEE80211_CONF_PS)) \
> > + ath9k_hw_setpower(sc->sc_ah, ah->ah_restoreMode); \
> > + } while (0);
>
> I think those would be better as static inlines rather than macros.
And the do-while c-block-protection of the macro is buggy. It has an extra
semicolon at the end, which defeats the whole purpose.
--
Greetings, Michael.
next prev parent reply other threads:[~2008-12-29 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 23:53 [PATCH] ath9k: Enable dynamic power save in ath9k Vivek Natarajan
2008-12-29 12:11 ` Johannes Berg
2008-12-29 12:14 ` Johannes Berg
2008-12-29 12:23 ` Michael Buesch [this message]
2008-12-29 13:37 ` Vivek Natarajan
2009-01-09 19:51 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812291323.54588.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).