From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Sujith Manoharan <Sujith.Manoharan@Atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH v3 02/16] ath9k: use hw->conf on ath_setcurmode()
Date: Mon, 29 Dec 2008 07:44:53 -0800 [thread overview]
Message-ID: <20081229154453.GP5944@tesla> (raw)
In-Reply-To: <18776.21485.750323.652519@gargle.gargle.HOWL>
On Sun, Dec 28, 2008 at 08:37:01PM -0800, Sujith Manoharan wrote:
> Luis Rodriguez wrote:
> > + switch (conf->channel->band) {
> > + case IEEE80211_BAND_2GHZ:
> > + if (conf_is_ht20(conf))
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11NG_HT20];
> > + else if (conf_is_ht40_minus(conf))
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11NG_HT40MINUS];
> > + else if (conf_is_ht40_plus(conf))
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11NG_HT40PLUS];
> > + else {
> > + sc->sc_protrix = 1;
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11G];
> > + }
> > + break;
> > + case IEEE80211_BAND_5GHZ:
> > + if (conf_is_ht20(conf))
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11NA_HT20];
> > + else if (conf_is_ht40_minus(conf))
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11NA_HT40MINUS];
> > + else if (conf_is_ht40_plus(conf))
> > + sc->cur_rate_table =
> > + sc->hw_rate_table[ATH9K_MODE_11NA_HT40PLUS];
> > + else
> > + sc->cur_rate_table = sc->hw_rate_table[ATH9K_MODE_11A];
> > + break;
> > + default:
> > + break;
> > + }
> > }
>
> We don't have separate rate tables for ht20, ht40+, ht40-.
> Setting cur_rate_table just once using conf_is_ht() to any HT mode would suffice.
I do see we have different rate tables for these though, do you mean we can
consolidate on the rate tables?
Luis
next prev parent reply other threads:[~2008-12-29 15:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 23:58 [PATCH v3 00/16] ath9k: first series for regulatory cleanup Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 01/16] mac80211: add HT conf helpers Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 02/16] ath9k: use hw->conf on ath_setcurmode() Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 03/16] ath9k: remove cache of rate preference when using 11g protection Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 04/16] ath9k: Rename ath_setcurmode() to ath_cache_conf_rate() Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 05/16] ath9k: consolidate arguments on hw reset Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 06/16] ath9k: make request to get the noisefloor threshold band specific Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 07/16] ath9k: use ieee80211_conf on ath9k_hw_iscal_supported() Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 08/16] ath9k: make use of conf_is_ht*() in the rest of the driver Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 09/16] iwlwifi: make use of conf_is_ht*() helpers Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 10/16] mac80211: no need for ht.enabled Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 11/16] ath9k: Make ANI CCK and OFDM error triggers band specific Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 12/16] ath9k: remove mode specific default noise floor values Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 13/16] ath9k: remove ath9k_hw_chan2wmode() Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 14/16] ath9k: remove ath9k_hw_check_chan() Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 15/16] ath9k: remove superfluous check on changing channel Luis R. Rodriguez
2008-12-23 23:58 ` [PATCH v3 16/16] ath9k: fix sparse warnings Luis R. Rodriguez
2008-12-29 4:38 ` [PATCH v3 07/16] ath9k: use ieee80211_conf on ath9k_hw_iscal_supported() Sujith
2008-12-29 15:46 ` Luis R. Rodriguez
2008-12-29 4:37 ` [PATCH v3 02/16] ath9k: use hw->conf on ath_setcurmode() Sujith
2008-12-29 15:44 ` Luis R. Rodriguez [this message]
[not found] ` <18776.62379.965798.668056@localhost.localdomain>
2008-12-29 16:44 ` [ath9k-devel] " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229154453.GP5944@tesla \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Sujith.Manoharan@Atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).