Re: [RFC] mac80211: Handle power constraint level advertised in 11d+h beacon

[Vasanthakumar Thiagarajan <vasanth@atheros.com>]

On Tue, Dec 30, 2008 at 08:38:15PM +0530, Tomas Winkler wrote:
> > +       /* TODO: for IBSS */
> 
> IIRC this particular feature of 11h is not supported in IBSS
> 

No, this is supported in IBSS also. See 11.8.2 of IEEE802.11-2007.pdf. 

> > +       if ((conf->channel->band != IEEE80211_BAND_5GHZ) ||
> > +           !(capab_info & WLAN_CAPABILITY_SPECTRUM_MGMT))
> > +               return;
> 
> I think our original patch removed need of IEEE80211_BAND_5GHZ as
> WLAN_CAPABILITY_SPECTRUM_MGMT
> is sufficient condition.
> 

Thats right, spectrum management is only for 5Ghz, will remove that
redundant check, thanks. 

> > +       /* Power constraint IE length should be 1 octet */
> > +       if (pwr_constr_elem_len != 1)
> > +               return;
> > +
> > +       if ((*pwr_constr_elem <= conf->channel->max_power) &&
> > +           (*pwr_constr_elem != conf->power_constr_level)) {
> 
> This is defined only when you receive country IE, how do you check for it?

The thing is AP should not send power constraint without country
element :), yeah, check is needed for the APs which dont do 11d + h
properly. 


Vasanth