From: Bob Copeland <me@bobcopeland.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
htl10@users.sourceforge.net,
Alan Stern <stern@rowland.harvard.edu>,
linux-wireless@vger.kernel.org,
linux-pm@lists.linux-foundation.org,
USB list <linux-usb@vger.kernel.org>,
Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Subject: Re: [linux-pm] rtl8187 usb wifi adaptor causes suspend hang
Date: Wed, 31 Dec 2008 18:26:09 -0500 [thread overview]
Message-ID: <20081231232609.GA27391@hash.localnet> (raw)
In-Reply-To: <495BF975.7030603@lwfinger.net>
On Wed, Dec 31, 2008 at 05:00:05PM -0600, Larry Finger wrote:
> +#ifdef CONFIG_PM
> +
> +static int rtl8187_suspend(struct usb_interface *intf, pm_message_t
> state)
> +{
> + struct ieee80211_hw *dev = usb_get_intfdata(intf);
> +
> + rtl8187_stop(dev);
> +
> + return 0;
> +}
Won't this do the wrong thing if the interface is never brought up
before you do suspend? (And then you can add a flag etc. to handle
that case, but that's exactly what my mac80211 patches aim to do.)
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-12-31 23:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 10:51 rtl8187 usb wifi adaptor causes suspend hang Alan Jenkins
2008-12-30 13:10 ` Alan Jenkins
2008-12-30 15:45 ` [linux-pm] " Alan Stern
2008-12-30 16:45 ` Bob Copeland
2008-12-30 16:48 ` Alan Jenkins
2008-12-30 17:25 ` Alan Stern
2008-12-30 17:31 ` Alan Jenkins
2008-12-30 17:52 ` Larry Finger
2008-12-30 18:05 ` Hin-Tak Leung
2008-12-30 18:05 ` Oliver Neukum
2008-12-30 18:09 ` Larry Finger
2008-12-31 0:59 ` Hin-Tak Leung
2008-12-31 14:33 ` Alan Jenkins
2008-12-31 15:57 ` Bob Copeland
2008-12-31 17:10 ` Alan Jenkins
2008-12-31 17:16 ` Oliver Neukum
2008-12-31 19:33 ` Larry Finger
2008-12-31 23:00 ` Larry Finger
2008-12-31 23:26 ` Bob Copeland [this message]
2009-01-01 0:16 ` Alan Stern
2009-01-01 6:06 ` Hin-Tak Leung
2009-01-01 22:25 ` Alan Stern
2009-01-01 23:42 ` Hin-Tak Leung
2009-01-02 2:24 ` Alan Stern
2009-01-01 6:18 ` Hin-Tak Leung
2009-01-01 13:07 ` Alan Jenkins
2009-01-01 13:40 ` Stefanik Gábor
2009-01-01 14:39 ` Hin-Tak Leung
2009-01-01 16:38 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231232609.GA27391@hash.localnet \
--to=me@bobcopeland.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).