* wifi: iwlwifi: fix documentation about initial values in station table
@ 2024-12-19 10:22 Rolf Eike Beer
2024-12-19 11:51 ` Korenblit, Miriam Rachel
0 siblings, 1 reply; 2+ messages in thread
From: Rolf Eike Beer @ 2024-12-19 10:22 UTC (permalink / raw)
To: Miri Korenblit; +Cc: linux-wireless, linux-kernel
The inverse value is stored in the table, make the documentation match the code.
Signed-off-by: Rolf Eike Beer <eb@emlix.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.h b/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
index 4a3799ae7c18..dbc531c63f0f 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
@@ -133,7 +133,7 @@ struct iwl_mvm_vif;
* and no TID data as this is also not needed.
* One thing to note, is that these stations have an ID in the fw, but not
* in mac80211. In order to "reserve" them a sta_id in %fw_id_to_mac_id
- * we fill ERR_PTR(EINVAL) in this mapping and all other dereferencing of
+ * we fill ERR_PTR(-EINVAL) in this mapping and all other dereferencing of
* pointers from this mapping need to check that the value is not error
* or NULL.
*
--
2.47.1
--
Rolf Eike Beer
emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com
emlix - your embedded Linux partner
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: wifi: iwlwifi: fix documentation about initial values in station table
2024-12-19 10:22 wifi: iwlwifi: fix documentation about initial values in station table Rolf Eike Beer
@ 2024-12-19 11:51 ` Korenblit, Miriam Rachel
0 siblings, 0 replies; 2+ messages in thread
From: Korenblit, Miriam Rachel @ 2024-12-19 11:51 UTC (permalink / raw)
To: Rolf Eike Beer
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Berg, Johannes
> -----Original Message-----
> From: Rolf Eike Beer <eb@emlix.com>
> Sent: Thursday, 19 December 2024 12:22
> To: Korenblit, Miriam Rachel <miriam.rachel.korenblit@intel.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: wifi: iwlwifi: fix documentation about initial values in station table
>
> The inverse value is stored in the table, make the documentation match the code.
>
> Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> b/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> index 4a3799ae7c18..dbc531c63f0f 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> @@ -133,7 +133,7 @@ struct iwl_mvm_vif;
> * and no TID data as this is also not needed.
> * One thing to note, is that these stations have an ID in the fw, but not
> * in mac80211. In order to "reserve" them a sta_id in %fw_id_to_mac_id
> - * we fill ERR_PTR(EINVAL) in this mapping and all other dereferencing of
> + * we fill ERR_PTR(-EINVAL) in this mapping and all other dereferencing of
> * pointers from this mapping need to check that the value is not error
> * or NULL.
> *
> --
> 2.47.1
>
>
> --
> Rolf Eike Beer
>
> emlix GmbH
> Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
> Phone +49 (0)551 30664-0, e-mail info@emlix.com
> District Court of Göttingen, Registry Number HR B 3160
> Managing Directors: Heike Jordan, Dr. Uwe Kracke
> VAT ID No. DE 205 198 055
> Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
> Office Bonn: Bachstr. 6, 53115 Bonn, Germany
> http://www.emlix.com
>
> emlix - your embedded Linux partner
>
Acked-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-19 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19 10:22 wifi: iwlwifi: fix documentation about initial values in station table Rolf Eike Beer
2024-12-19 11:51 ` Korenblit, Miriam Rachel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox