From: Ivo van Doorn <ivdoorn@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Andrew Price <andy@andrewprice.me.uk>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rt2x00: Fix radio LED type check
Date: Fri, 2 Jan 2009 15:21:20 +0100 [thread overview]
Message-ID: <200901021521.20500.IvDoorn@gmail.com> (raw)
In-Reply-To: <1230905414.15391.39.camel@californication>
On Friday 02 January 2009, Marcel Holtmann wrote:
> Hi Ivo,
>
> > > Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> > > state handling", rt2x00leds_led_radio wrongly checks that the LED type
> > > is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> > > again.
> > >
> > > Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> >
> > Good catch. Thanks.
> >
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
>
> small comment from my side here. Signed-off-by is only suppose to be
> used if you pick up the patch and then send it to John by yourself. If
> you just wanna indicate that it is fine for John to pick up this patch,
> then it should be an Acked-by: line.
>
> The Signed-off-by should indicate the steps (aka persons) this patch
> when through until it reached Linus. This doesn't include people testing
> or acknowledging a patch.
Ok, feel free to change it to a Acked-by then. ;)
Ivo
next prev parent reply other threads:[~2009-01-02 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 8:05 [PATCH] rt2x00: Fix radio LED type check Andrew Price
2009-01-02 11:14 ` Ivo Van Doorn
2009-01-02 14:10 ` Marcel Holtmann
2009-01-02 14:21 ` Ivo van Doorn [this message]
2009-01-08 18:10 ` Andrew Price
2009-01-08 18:49 ` Ivo van Doorn
2009-01-08 18:50 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901021521.20500.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=andy@andrewprice.me.uk \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).