[PATCH] rt2x00: Fix radio LED type check

[PATCH] rt2x00: Fix radio LED type check

[Andrew Price]

Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
state handling", rt2x00leds_led_radio wrongly checks that the LED type
is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
again.

Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
---
 drivers/net/wireless/rt2x00/rt2x00leds.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00leds.c b/drivers/net/wireless/rt2x00/rt2x00leds.c
index 68f4e0f..a0cd35b 100644
--- a/drivers/net/wireless/rt2x00/rt2x00leds.c
+++ b/drivers/net/wireless/rt2x00/rt2x00leds.c
@@ -97,7 +97,7 @@ void rt2x00leds_led_assoc(struct rt2x00_dev *rt2x00dev, bool enabled)
 
 void rt2x00leds_led_radio(struct rt2x00_dev *rt2x00dev, bool enabled)
 {
-	if (rt2x00dev->led_radio.type == LED_TYPE_ASSOC)
+	if (rt2x00dev->led_radio.type == LED_TYPE_RADIO)
 		rt2x00led_led_simple(&rt2x00dev->led_radio, enabled);
 }
 
-- 
1.5.6.5

Re: [PATCH] rt2x00: Fix radio LED type check

[Ivo Van Doorn]

On Fri, Jan 2, 2009 at 9:05 AM, Andrew Price <andy@andrewprice.me.uk> wrote:
> Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> state handling", rt2x00leds_led_radio wrongly checks that the LED type
> is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> again.
>
> Signed-off-by: Andrew Price <andy@andrewprice.me.uk>

Good catch. Thanks.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00leds.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00leds.c b/drivers/net/wireless/rt2x00/rt2x00leds.c
> index 68f4e0f..a0cd35b 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00leds.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00leds.c
> @@ -97,7 +97,7 @@ void rt2x00leds_led_assoc(struct rt2x00_dev *rt2x00dev, bool enabled)
>
>  void rt2x00leds_led_radio(struct rt2x00_dev *rt2x00dev, bool enabled)
>  {
> -       if (rt2x00dev->led_radio.type == LED_TYPE_ASSOC)
> +       if (rt2x00dev->led_radio.type == LED_TYPE_RADIO)
>                rt2x00led_led_simple(&rt2x00dev->led_radio, enabled);
>  }
>
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] rt2x00: Fix radio LED type check

[Marcel Holtmann]

Hi Ivo,

> > Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> > state handling", rt2x00leds_led_radio wrongly checks that the LED type
> > is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> > again.
> >
> > Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> 
> Good catch. Thanks.
> 
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>

small comment from my side here. Signed-off-by is only suppose to be
used if you pick up the patch and then send it to John by yourself. If
you just wanna indicate that it is fine for John to pick up this patch,
then it should be an Acked-by: line.

The Signed-off-by should indicate the steps (aka persons) this patch
when through until it reached Linus. This doesn't include people testing
or acknowledging a patch.

Regards

Marcel

Re: [PATCH] rt2x00: Fix radio LED type check

[Ivo van Doorn]

On Friday 02 January 2009, Marcel Holtmann wrote:
> Hi Ivo,
> 
> > > Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> > > state handling", rt2x00leds_led_radio wrongly checks that the LED type
> > > is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> > > again.
> > >
> > > Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> > 
> > Good catch. Thanks.
> > 
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> small comment from my side here. Signed-off-by is only suppose to be
> used if you pick up the patch and then send it to John by yourself. If
> you just wanna indicate that it is fine for John to pick up this patch,
> then it should be an Acked-by: line.
> 
> The Signed-off-by should indicate the steps (aka persons) this patch
> when through until it reached Linus. This doesn't include people testing
> or acknowledging a patch.

Ok, feel free to change it to a Acked-by then. ;)

Ivo

Re: [PATCH] rt2x00: Fix radio LED type check

[Andrew Price]

On Fri, Jan 02, 2009 at 12:14:17PM +0100, Ivo Van Doorn wrote:
> On Fri, Jan 2, 2009 at 9:05 AM, Andrew Price <andy@andrewprice.me.uk> wrote:
> > Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> > state handling", rt2x00leds_led_radio wrongly checks that the LED type
> > is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> > again.
> >
> > Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> 
> Good catch. Thanks.
> 
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

Thanks for that. I'm a little new to this so I'm not sure what happens now.
Will the patch go into John's tree and make it's way to Linus' tree (where the
bug is) or should I send it directly to Linus/LKML with Ivo's Acked-by line?

Regards,

--
Andrew Price

Re: [PATCH] rt2x00: Fix radio LED type check

[Ivo van Doorn]

On Thursday 08 January 2009, Andrew Price wrote:
> On Fri, Jan 02, 2009 at 12:14:17PM +0100, Ivo Van Doorn wrote:
> > On Fri, Jan 2, 2009 at 9:05 AM, Andrew Price <andy@andrewprice.me.uk> wrote:
> > > Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> > > state handling", rt2x00leds_led_radio wrongly checks that the LED type
> > > is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> > > again.
> > >
> > > Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> > 
> > Good catch. Thanks.
> > 
> > Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> Thanks for that. I'm a little new to this so I'm not sure what happens now.
> Will the patch go into John's tree and make it's way to Linus' tree (where the
> bug is) or should I send it directly to Linus/LKML with Ivo's Acked-by line?

I had added John to the CC list in my initial reply to notify him of the patch,
he will pick up the patch and make sure it will make its way to Linus. :)

Ivo

Re: [PATCH] rt2x00: Fix radio LED type check

[John W. Linville]

On Thu, Jan 08, 2009 at 06:10:35PM +0000, Andrew Price wrote:
> On Fri, Jan 02, 2009 at 12:14:17PM +0100, Ivo Van Doorn wrote:
> > On Fri, Jan 2, 2009 at 9:05 AM, Andrew Price <andy@andrewprice.me.uk> wrote:
> > > Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED
> > > state handling", rt2x00leds_led_radio wrongly checks that the LED type
> > > is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once
> > > again.
> > >
> > > Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> > 
> > Good catch. Thanks.
> > 
> > Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> Thanks for that. I'm a little new to this so I'm not sure what happens now.
> Will the patch go into John's tree and make it's way to Linus' tree (where the
> bug is) or should I send it directly to Linus/LKML with Ivo's Acked-by line?

I've got it, thanks.

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.