Re: [PATCH] ath9k: Enforce module build if rfkill is a module

[Ingo Molnar <mingo@elte.hu>]

* Jouni Malinen <jouni.malinen@atheros.com> wrote:

> CONFIG_ATH9K=y results in build issues if CONFIG_RFKILL=m since ath9k
> does not depend on rfkill in kconfig (i.e., CONFIG_RFKILL is used to
> select whether to enable rfkill in ath9k), but uses its functions if
> rfkill is enabled. Enforce ath9k to be build as a module if
> CONFIG_RFKILL=m to avoid this invalid configuration.
> 
> Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
> 
> ---
>  drivers/net/wireless/ath9k/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- wireless-testing.orig/drivers/net/wireless/ath9k/Kconfig	2009-01-05 13:27:01.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/ath9k/Kconfig	2009-01-05 13:36:27.000000000 +0200
> @@ -1,6 +1,7 @@
>  config ATH9K
>  	tristate "Atheros 802.11n wireless cards support"
>  	depends on PCI && MAC80211 && WLAN_80211
> +	depends on RFKILL || RFKILL=n
>  	select MAC80211_LEDS
>  	select LEDS_CLASS
>  	select NEW_LEDS

thanks - i'll let you know if there's still any build failures in this 
area. (Sidenote: next time around please also add a Reported-by line 
crediting bugreporters. Doesnt matter to me but matters to contributors 
and testers in general.)

	Ingo