From: "Bob Copeland" <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Dan Williams <dcbw@redhat.com>,
Marcel Holtmann <marcel@holtmann.org>,
linux-wireless@vger.kernel.org, mabbaswireless@gmail.com
Subject: Re: [PATCH v2 0/3] mac80211 suspend/resume
Date: Tue, 6 Jan 2009 12:35:11 -0500 [thread overview]
Message-ID: <20090106172758.M47578@bobcopeland.com> (raw)
In-Reply-To: <1231262082.3654.5.camel@johannes>
On Tue, 06 Jan 2009 18:14:41 +0100, Johannes Berg wrote
> > However, _with_ the current procedure of telling NM to go to sleep, it
> > tries to reconnect after resume because NM takes care of downing the
> > interfaces. As a result mac80211 never gets the chance to save the
> > state of the running interfaces.
>
> You mean restore?
>
> Does that mean there's a race condition now, between userspace config
> and the resume stuff? Can't we fix that by taking the rtnl?
No, I mean that with dbus telling NM to go to sleep (as part of pm-utils)
NM then takes down the interfaces -- userspace is still running, this is
before the kernel actually suspends.
Consequently, all the interfaces look down to mac80211 when suspend() is
actually called so the suspend/resume in mac80211 doesn't wind up doing
anything with interfaces. No race condition, but a re-association must
happen from userspace on the resume side (NM will do this, though).
At least this appears the case on f10, correct me if I'm wrong, Dan.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-01-06 17:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 3:50 [PATCH v2 0/3] mac80211 suspend/resume Bob Copeland
2008-12-15 10:14 ` Johannes Berg
2008-12-15 15:22 ` Dan Williams
2008-12-15 9:28 ` Luis R. Rodriguez
2008-12-17 18:21 ` Bob Copeland
2008-12-23 20:30 ` Johannes Berg
2008-12-24 5:49 ` Bob Copeland
2008-12-24 7:16 ` Marcel Holtmann
2009-01-06 16:45 ` Dan Williams
2009-01-06 17:07 ` Bob Copeland
2009-01-06 17:14 ` Johannes Berg
2009-01-06 17:35 ` Bob Copeland [this message]
2009-01-06 17:43 ` Johannes Berg
2009-01-06 18:01 ` Bob Copeland
2009-01-06 18:16 ` Johannes Berg
2009-01-06 17:12 ` Marcel Holtmann
2009-01-06 18:52 ` Dan Williams
2009-01-06 19:36 ` Marcel Holtmann
2009-01-06 20:05 ` Johannes Berg
2009-01-09 23:53 ` Tomas Winkler
2009-01-10 9:27 ` Johannes Berg
2009-01-11 11:11 ` Tomas Winkler
2009-01-11 14:40 ` Bob Copeland
2009-01-08 16:39 ` Dan Williams
2009-01-09 7:55 ` Kalle Valo
2009-01-09 16:35 ` Dan Williams
2009-01-09 16:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106172758.M47578@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mabbaswireless@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).