Re: [PATCH] rt2x00: Provide regulatory hint with rt2500pci/usb

[Ivo van Doorn <ivdoorn@gmail.com>]

> >    
> >> The problem isn't there for the bits that Ivo sent, as the rt2500 devices don't support the a band.
> >>      
> >
> > For rt2500pci and rt2500usb there are chipsets which support 5GHz (they are rare, but they do exist),
> > comments for the Ralink drivers indicate they simply didn't add the regulatory domain definitions yet.
> >    
> 
> OK. But the EEPROM definitions I got from Ralink on the Country 
> information indicate that there is only a single indication in the EEPROM.

That is right, like I said the comments already indicates there the legacy code didn't contain the
definitions (yet). ;)

> > GertJan, some comments about your patch:
> >
> >    
> >> diff --git a/drivers/net/wireless/rt2x00/rt2400pci.h b/drivers/net/wireless/rt2x00/rt2400pci.h
> >> index 9aefda4..986e428 100644
> >> --- a/drivers/net/wireless/rt2x00/rt2400pci.h
> >> +++ b/drivers/net/wireless/rt2x00/rt2400pci.h
> >> @@ -806,6 +806,13 @@
> >>   #define EEPROM_TXPOWER_2		FIELD16(0xff00)
> >>
> >>   /*
> >> + * EEPROM geography.
> >> + * GEO: Default geography setting for device.
> >> + */
> >> +#define EEPROM_GEOGRAPHY		0x17
> >> +#define EEPROM_GEOGRAPHY_GEO		FIELD16(0xff00)
> >>      
> >
> > Where did you find this definition? I couldn't find it in the legacy driver or the specsheets.
> >    
> 
> I got an excerpt from the EEPROM definition for the rt2460 chip (which I 
> received with the help of Luis). It's defined in there.

I assume you mean the file RT2460_DS_P1.3.pdf, could you point me to the right pagenumber?

> >> diff --git a/drivers/net/wireless/rt2x00/rt2500pci.h b/drivers/net/wireless/rt2x00/rt2500pci.h
> >> index e135247..8a69af3 100644
> >> --- a/drivers/net/wireless/rt2x00/rt2500pci.h
> >> +++ b/drivers/net/wireless/rt2x00/rt2500pci.h
> >> @@ -1060,7 +1060,7 @@
> >>    * GEO: Default geography setting for device.
> >>    */
> >>   #define EEPROM_GEOGRAPHY		0x12
> >> -#define EEPROM_GEOGRAPHY_GEO		FIELD16(0x0f00)
> >> +#define EEPROM_GEOGRAPHY_GEO		FIELD16(0xff00)
> >>      
> >
> > Legacy driver uses 0x0f00, and the definition indicates the max value is 7,
> > so extending the definition doesn't seem correct.
> >    
> 
> Well, the EEPROM definition indicates that this is an 8-bit field, so 
> updating it looked appropriate, although the max value indeed is 7.

Ok, apparently I messed up the code interpretation. :S, the change from 0xf to 0xff is fine.

Ivo