Re: drivers returning wrong results from their _tx op

["Bob Copeland" <me@bobcopeland.com>]

On Fri, 09 Jan 2009 10:13:56 +0200, Kalle Valo wrote
> > @@ -1170,6 +1170,7 @@ enum ieee80211_ampdu_mlme_action {
> >   *	configuration in the TX control data. This handler should,
> >   *	preferably, never fail and stop queues appropriately, more
> >   *	importantly, however, it must never fail for A-MPDU-queues.
> > + *	Returns NETDEV_TX_OK, or NETDEV_TX_BUSY if it fails.
> >   *	Must be implemented and atomic.
> 
> Based on discussion from netdev I have understood that NETDEV_TX_BUSY
> is not recommended, it's better to stop the queue already earlier,
> drop the frame or store the skb somewhere else temporarily. Johannes,
> have I understood this correctly?
> 
> It would be nice to have this documented here.

Read the sentence before the added line :-)

I was just interested in what all the callbacks hope to return.  
There seem to be some discrepancies, e.g. tx_last_beacon returns a 
bool disguised as an int (0=failure), while get_stats returns an 
error code but only checks for 0=OK.  Whether the documentation is
ultimately worthwhile or not is an open question.

Also, unless my grep-fu is weak, get_tx_stats didn't seem to be 
used at all.

-- 
Bob Copeland %% www.bobcopeland.com