From: "Bob Copeland" <me@bobcopeland.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
linville@tuxdriver.com
Subject: Re: drivers returning wrong results from their _tx op
Date: Fri, 9 Jan 2009 13:27:27 -0500 [thread overview]
Message-ID: <20090109182142.M2510@bobcopeland.com> (raw)
In-Reply-To: <87hc48tpwa.fsf@litku.valot.fi>
On Fri, 09 Jan 2009 18:17:41 +0200, Kalle Valo wrote
> I read it. Adding "or NETDEV_TX_BUSY if it fails" is just confusing,
> better to state that it just should not fail.
Fair enough, but the state of things today is some drivers do.
Yes, we're guilty of that in ath5k and it should be fixed. But like
->config(), if the callback should never ever fail, then returning
an error code at all is pretty suspect. Would this be better?
"This function should return NETDEV_TX_OK except in very limited cases."
Then when someone asks which cases, you say "none"...
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-01-09 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 22:07 drivers returning wrong results from their _tx op Johannes Berg
2009-01-05 22:24 ` Bob Copeland
2009-01-06 13:00 ` Johannes Berg
2009-01-09 2:23 ` Bob Copeland
2009-01-09 8:13 ` Kalle Valo
2009-01-09 10:06 ` Johannes Berg
2009-01-09 15:44 ` Bob Copeland
2009-01-09 16:17 ` Kalle Valo
2009-01-09 18:27 ` Bob Copeland [this message]
2009-01-09 18:47 ` Kalle Valo
2009-01-11 3:12 ` Bob Copeland
2009-01-11 6:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109182142.M2510@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).