From: "Alina Friedrichsen" <x-alina@gmx.net>
To: Jouni Malinen <j@w1.fi>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Fixed BSSID step 3: Don't merge with the same BSSID
Date: Fri, 09 Jan 2009 21:53:15 +0100 [thread overview]
Message-ID: <20090109205315.277310@gmx.net> (raw)
In-Reply-To: <20090108091055.GA7009@jm.kir.nu>
Hi Jouni!
> I agree that merge part (updating Beacon/ProbeRsp data) can be skippe=
d
> for same BSSID, but this change seems to break timesync by removing c=
all
> to local->ops->reset_tsf(). I don't think that that should be removed
> unconditionally.
Thanks for your comment.
> I would like to know whether that operation is causing
> any problems in citywide networks and if yes, it might be better to
> provide a configuration option to allow the timesync for IBSS to be
> disabled since not doing that could cause problems to power saving in
> IBSS (not that it is really implemented that widely).
As I see, only the sta_info_flush_delayed() call causes the problems. I=
can only disable this call in the ieee80211_sta_join_ibss() function, =
if the BSSID is the same. Do you think this would be better?
> In other words, I would be fine if the calls to
> ieee80211_sta_join_ibss() and ieee80211_ibss_add_sta() are replaced w=
ith
> local->ops->reset_tsf() if BSSIDs are the same when
> beacon_timestamp>rx_timestamp.
This would be a way, too.
Regards
Alina
--=20
Sensationsangebot verl=E4ngert: GMX FreeDSL - Telefonanschluss + DSL=20
f=FCr nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K1308T45=
69a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-09 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 2:01 [PATCH] Fixed BSSID step 3: Don't merge with the same BSSID Alina Friedrichsen
2009-01-08 9:10 ` Jouni Malinen
2009-01-09 20:53 ` Alina Friedrichsen [this message]
2009-01-10 9:16 ` Jouni Malinen
2009-01-12 4:15 ` Alina Friedrichsen
2009-01-12 17:35 ` Jouni Malinen
2009-01-17 3:39 ` [PATCH] Fixed BSSID (timesync) Alina Friedrichsen
2009-01-17 3:51 ` Alina Friedrichsen
2009-01-17 22:12 ` [PATCH] Fixed BSSID step 3: Don't merge with the same BSSID Alina Friedrichsen
2009-01-20 15:10 ` Jouni Malinen
2009-01-20 18:56 ` Alina Friedrichsen
2009-01-21 8:45 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109205315.277310@gmx.net \
--to=x-alina@gmx.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).