From: "John W. Linville" <linville@tuxdriver.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: [PATCH 1/1 #2] IWL: fix WARN typo
Date: Fri, 9 Jan 2009 16:42:16 -0500 [thread overview]
Message-ID: <20090109214216.GG3371@tuxdriver.com> (raw)
In-Reply-To: <20090109201759.GE3371@tuxdriver.com>
People have pointed-out the "kew -> key" part of the patch.
Any thoughts on "new key" vs. "a new key"?
John
On Fri, Jan 09, 2009 at 03:18:00PM -0500, John W. Linville wrote:
> Is the way it is now problematic for non-native English speakers?
> Or native ones for that matter?
>
> Dropping an article in a "computer-ese" statement has never bothered
> me, so this seems like just a handful of unnecessary string bytes?
>
> John
>
> On Mon, Jan 05, 2009 at 05:06:06PM +0100, Jiri Slaby wrote:
> > new kew -> a new key
> >
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> > Cc: Tomas Winkler <tomas.winkler@intel.com>
> > Cc: John W. Linville <linville@tuxdriver.com>
> > ---
> > drivers/net/wireless/iwlwifi/iwl-sta.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
> > index 412f66b..ce2ba40 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
> > @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv,
> > * in uCode. */
> >
> > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
> > - "no space for new kew");
> > + "no space for a new key");
> >
> > priv->stations[sta_id].sta.key.key_flags = key_flags;
> > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK;
> > @@ -686,7 +686,7 @@ static int iwl_set_ccmp_dynamic_key_info(struct iwl_priv *priv,
> > * in uCode. */
> >
> > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
> > - "no space for new kew");
> > + "no space for a new key");
> >
> > priv->stations[sta_id].sta.key.key_flags = key_flags;
> > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK;
> > @@ -722,7 +722,7 @@ static int iwl_set_tkip_dynamic_key_info(struct iwl_priv *priv,
> > * in uCode. */
> >
> > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
> > - "no space for new kew");
> > + "no space for a new key");
> >
> > /* This copy is acutally not needed: we get the key with each TX */
> > memcpy(priv->stations[sta_id].keyinfo.key, keyconf->key, 16);
> > --
> > 1.6.0.6
> >
> >
>
> --
> John W. Linville Linux should be at the core
> linville@tuxdriver.com of your literate lifestyle.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
next prev parent reply other threads:[~2009-01-09 21:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 16:03 [PATCH 1/1] IWL: fix WARN typo Jiri Slaby
2009-01-05 16:04 ` Jiri Slaby
2009-01-05 16:06 ` [PATCH 1/1 #2] " Jiri Slaby
2009-01-09 20:18 ` John W. Linville
2009-01-09 21:42 ` John W. Linville [this message]
2009-01-09 22:20 ` Johannes Berg
2009-01-05 19:02 ` [PATCH 1/1] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109214216.GG3371@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).