From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:34087 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbZAIVpm (ORCPT ); Fri, 9 Jan 2009 16:45:42 -0500 Date: Fri, 9 Jan 2009 16:42:16 -0500 From: "John W. Linville" To: Jiri Slaby Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tomas Winkler Subject: Re: [PATCH 1/1 #2] IWL: fix WARN typo Message-ID: <20090109214216.GG3371@tuxdriver.com> (sfid-20090109_224547_996637_901AF36B) References: <1231171404-22822-1-git-send-email-jirislaby@gmail.com> <1231171566-22984-1-git-send-email-jirislaby@gmail.com> <20090109201759.GE3371@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20090109201759.GE3371@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: People have pointed-out the "kew -> key" part of the patch. Any thoughts on "new key" vs. "a new key"? John On Fri, Jan 09, 2009 at 03:18:00PM -0500, John W. Linville wrote: > Is the way it is now problematic for non-native English speakers? > Or native ones for that matter? > > Dropping an article in a "computer-ese" statement has never bothered > me, so this seems like just a handful of unnecessary string bytes? > > John > > On Mon, Jan 05, 2009 at 05:06:06PM +0100, Jiri Slaby wrote: > > new kew -> a new key > > > > Signed-off-by: Jiri Slaby > > Cc: Tomas Winkler > > Cc: John W. Linville > > --- > > drivers/net/wireless/iwlwifi/iwl-sta.c | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c > > index 412f66b..ce2ba40 100644 > > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c > > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c > > @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv, > > * in uCode. */ > > > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > > - "no space for new kew"); > > + "no space for a new key"); > > > > priv->stations[sta_id].sta.key.key_flags = key_flags; > > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; > > @@ -686,7 +686,7 @@ static int iwl_set_ccmp_dynamic_key_info(struct iwl_priv *priv, > > * in uCode. */ > > > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > > - "no space for new kew"); > > + "no space for a new key"); > > > > priv->stations[sta_id].sta.key.key_flags = key_flags; > > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; > > @@ -722,7 +722,7 @@ static int iwl_set_tkip_dynamic_key_info(struct iwl_priv *priv, > > * in uCode. */ > > > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > > - "no space for new kew"); > > + "no space for a new key"); > > > > /* This copy is acutally not needed: we get the key with each TX */ > > memcpy(priv->stations[sta_id].keyinfo.key, keyconf->key, 16); > > -- > > 1.6.0.6 > > > > > > -- > John W. Linville Linux should be at the core > linville@tuxdriver.com of your literate lifestyle. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle.