From: Andrew Price <andy@andrewprice.me.uk>
To: linux-wireless@vger.kernel.org
Subject: [RFC] rt2500pci: turn on led_qual for default LED mode
Date: Sat, 10 Jan 2009 10:07:52 +0000 [thread overview]
Message-ID: <20090110100751.GA29761@silver.sucs.org> (raw)
Add a check for LED_MODE_DEFAULT so that we initialise the link LED.
Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
---
I'm submitting this patch just as an RFC as I have no idea whether it works
with all rt2500pci devices. With my card, value holds 0 after the call to
rt2x00_get_field16() and so the added check for LED_MODE_DEFAULT (which is 0)
is needed for the link LED to work.
My card is a "RaLink RT2500 802.11g Cardbus/mini-PCI [1814:0201]" Belkin
F5D7010 according to lspci.
Any advice would be much appreciated. Does this patch look reasonable? Are
there any docs/specs which I could read to learn how this should be handled?
P.S. This is not related to my previous LED patch. This one is for the other
LED which has never worked as far as I can remember, until now :-)
diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
index d3bc218..651cb4f 100644
--- a/drivers/net/wireless/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/rt2x00/rt2500pci.c
@@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
- if (value == LED_MODE_TXRX_ACTIVITY)
+ if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
LED_TYPE_ACTIVITY);
#endif /* CONFIG_RT2X00_LIB_LEDS */
--
1.5.6.5
next reply other threads:[~2009-01-10 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 10:07 Andrew Price [this message]
2009-01-10 11:17 ` [RFC] rt2500pci: turn on led_qual for default LED mode Ivo van Doorn
2009-01-10 12:45 ` Ivo van Doorn
2009-01-10 19:38 ` [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT Andrew Price
2009-01-10 23:26 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110100751.GA29761@silver.sucs.org \
--to=andy@andrewprice.me.uk \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).