From: Ivo van Doorn <ivdoorn@gmail.com>
To: Andrew Price <andy@andrewprice.me.uk>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT
Date: Sun, 11 Jan 2009 00:26:10 +0100 [thread overview]
Message-ID: <200901110026.10562.IvDoorn@gmail.com> (raw)
In-Reply-To: <20090110193805.GA13086@silver.sucs.org>
On Saturday 10 January 2009, Andrew Price wrote:
> Add a check for LED_MODE_DEFAULT so that we use the link LED for rt2400
> and rt2500 devices.
>
> Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c
> index 6a97767..b86400d 100644
> --- a/drivers/net/wireless/rt2x00/rt2400pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2400pci.c
> @@ -1365,7 +1365,7 @@ static int rt2400pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2400pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2400pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
> diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
> index d3bc218..651cb4f 100644
> --- a/drivers/net/wireless/rt2x00/rt2500pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2500pci.c
> @@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
> diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> index 30028e2..c8e38a5 100644
> --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> @@ -1569,7 +1569,7 @@ static int rt2500usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2500usb_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2500usb_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
prev parent reply other threads:[~2009-01-10 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 10:07 [RFC] rt2500pci: turn on led_qual for default LED mode Andrew Price
2009-01-10 11:17 ` Ivo van Doorn
2009-01-10 12:45 ` Ivo van Doorn
2009-01-10 19:38 ` [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT Andrew Price
2009-01-10 23:26 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901110026.10562.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=andy@andrewprice.me.uk \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).