* [RFC] rt2500pci: turn on led_qual for default LED mode
@ 2009-01-10 10:07 Andrew Price
2009-01-10 11:17 ` Ivo van Doorn
2009-01-10 12:45 ` Ivo van Doorn
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Price @ 2009-01-10 10:07 UTC (permalink / raw)
To: linux-wireless
Add a check for LED_MODE_DEFAULT so that we initialise the link LED.
Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
---
I'm submitting this patch just as an RFC as I have no idea whether it works
with all rt2500pci devices. With my card, value holds 0 after the call to
rt2x00_get_field16() and so the added check for LED_MODE_DEFAULT (which is 0)
is needed for the link LED to work.
My card is a "RaLink RT2500 802.11g Cardbus/mini-PCI [1814:0201]" Belkin
F5D7010 according to lspci.
Any advice would be much appreciated. Does this patch look reasonable? Are
there any docs/specs which I could read to learn how this should be handled?
P.S. This is not related to my previous LED patch. This one is for the other
LED which has never worked as far as I can remember, until now :-)
diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
index d3bc218..651cb4f 100644
--- a/drivers/net/wireless/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/rt2x00/rt2500pci.c
@@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
- if (value == LED_MODE_TXRX_ACTIVITY)
+ if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
LED_TYPE_ACTIVITY);
#endif /* CONFIG_RT2X00_LIB_LEDS */
--
1.5.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC] rt2500pci: turn on led_qual for default LED mode
2009-01-10 10:07 [RFC] rt2500pci: turn on led_qual for default LED mode Andrew Price
@ 2009-01-10 11:17 ` Ivo van Doorn
2009-01-10 12:45 ` Ivo van Doorn
1 sibling, 0 replies; 5+ messages in thread
From: Ivo van Doorn @ 2009-01-10 11:17 UTC (permalink / raw)
To: Andrew Price; +Cc: linux-wireless
Hi,
> Add a check for LED_MODE_DEFAULT so that we initialise the link LED.
>
> Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> ---
>
> I'm submitting this patch just as an RFC as I have no idea whether it works
> with all rt2500pci devices. With my card, value holds 0 after the call to
> rt2x00_get_field16() and so the added check for LED_MODE_DEFAULT (which is 0)
> is needed for the link LED to work.
>
> My card is a "RaLink RT2500 802.11g Cardbus/mini-PCI [1814:0201]" Belkin
> F5D7010 according to lspci.
>
> Any advice would be much appreciated. Does this patch look reasonable? Are
> there any docs/specs which I could read to learn how this should be handled?
You raise a very good point with this patch, I need to double check what the legacy drivers
actually do with LED_MODE_DEFAULT and if it is similar as your approach this patch should
be done for all rt2x00 drivers.
I'll get back on this patch as soon as possible.
Thanks,
Ivo
> diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
> index d3bc218..651cb4f 100644
> --- a/drivers/net/wireless/rt2x00/rt2500pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2500pci.c
> @@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC] rt2500pci: turn on led_qual for default LED mode
2009-01-10 10:07 [RFC] rt2500pci: turn on led_qual for default LED mode Andrew Price
2009-01-10 11:17 ` Ivo van Doorn
@ 2009-01-10 12:45 ` Ivo van Doorn
2009-01-10 19:38 ` [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT Andrew Price
1 sibling, 1 reply; 5+ messages in thread
From: Ivo van Doorn @ 2009-01-10 12:45 UTC (permalink / raw)
To: Andrew Price; +Cc: linux-wireless
On Saturday 10 January 2009, Andrew Price wrote:
> Add a check for LED_MODE_DEFAULT so that we initialise the link LED.
>
> Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
> ---
>
> I'm submitting this patch just as an RFC as I have no idea whether it works
> with all rt2500pci devices. With my card, value holds 0 after the call to
> rt2x00_get_field16() and so the added check for LED_MODE_DEFAULT (which is 0)
> is needed for the link LED to work.
>
> My card is a "RaLink RT2500 802.11g Cardbus/mini-PCI [1814:0201]" Belkin
> F5D7010 according to lspci.
>
> Any advice would be much appreciated. Does this patch look reasonable? Are
> there any docs/specs which I could read to learn how this should be handled?
>
> P.S. This is not related to my previous LED patch. This one is for the other
> LED which has never worked as far as I can remember, until now :-)
Ok, I just checked legacy driver and LED_MODE_DEFAULT indeed can be considered
as LED_MODE_TXRX_ACTIVITY. Could you resend this patch as normal patch,
but with the same change for rt2400pci and rt2500usb.
Thanks,
> diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
> index d3bc218..651cb4f 100644
> --- a/drivers/net/wireless/rt2x00/rt2500pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2500pci.c
> @@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT
2009-01-10 12:45 ` Ivo van Doorn
@ 2009-01-10 19:38 ` Andrew Price
2009-01-10 23:26 ` Ivo van Doorn
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Price @ 2009-01-10 19:38 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Ivo Van Doorn
Add a check for LED_MODE_DEFAULT so that we use the link LED for rt2400
and rt2500 devices.
Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c
index 6a97767..b86400d 100644
--- a/drivers/net/wireless/rt2x00/rt2400pci.c
+++ b/drivers/net/wireless/rt2x00/rt2400pci.c
@@ -1365,7 +1365,7 @@ static int rt2400pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
rt2400pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
- if (value == LED_MODE_TXRX_ACTIVITY)
+ if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
rt2400pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
LED_TYPE_ACTIVITY);
#endif /* CONFIG_RT2X00_LIB_LEDS */
diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
index d3bc218..651cb4f 100644
--- a/drivers/net/wireless/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/rt2x00/rt2500pci.c
@@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
- if (value == LED_MODE_TXRX_ACTIVITY)
+ if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
LED_TYPE_ACTIVITY);
#endif /* CONFIG_RT2X00_LIB_LEDS */
diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
index 30028e2..c8e38a5 100644
--- a/drivers/net/wireless/rt2x00/rt2500usb.c
+++ b/drivers/net/wireless/rt2x00/rt2500usb.c
@@ -1569,7 +1569,7 @@ static int rt2500usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
rt2500usb_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
- if (value == LED_MODE_TXRX_ACTIVITY)
+ if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
rt2500usb_init_led(rt2x00dev, &rt2x00dev->led_qual,
LED_TYPE_ACTIVITY);
#endif /* CONFIG_RT2X00_LIB_LEDS */
--
1.5.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT
2009-01-10 19:38 ` [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT Andrew Price
@ 2009-01-10 23:26 ` Ivo van Doorn
0 siblings, 0 replies; 5+ messages in thread
From: Ivo van Doorn @ 2009-01-10 23:26 UTC (permalink / raw)
To: Andrew Price; +Cc: John W. Linville, linux-wireless
On Saturday 10 January 2009, Andrew Price wrote:
> Add a check for LED_MODE_DEFAULT so that we use the link LED for rt2400
> and rt2500 devices.
>
> Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c
> index 6a97767..b86400d 100644
> --- a/drivers/net/wireless/rt2x00/rt2400pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2400pci.c
> @@ -1365,7 +1365,7 @@ static int rt2400pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2400pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2400pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
> diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
> index d3bc218..651cb4f 100644
> --- a/drivers/net/wireless/rt2x00/rt2500pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2500pci.c
> @@ -1524,7 +1524,7 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2500pci_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
> diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> index 30028e2..c8e38a5 100644
> --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> @@ -1569,7 +1569,7 @@ static int rt2500usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
> value = rt2x00_get_field16(eeprom, EEPROM_ANTENNA_LED_MODE);
>
> rt2500usb_init_led(rt2x00dev, &rt2x00dev->led_radio, LED_TYPE_RADIO);
> - if (value == LED_MODE_TXRX_ACTIVITY)
> + if (value == LED_MODE_TXRX_ACTIVITY || value == LED_MODE_DEFAULT)
> rt2500usb_init_led(rt2x00dev, &rt2x00dev->led_qual,
> LED_TYPE_ACTIVITY);
> #endif /* CONFIG_RT2X00_LIB_LEDS */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-10 23:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-10 10:07 [RFC] rt2500pci: turn on led_qual for default LED mode Andrew Price
2009-01-10 11:17 ` Ivo van Doorn
2009-01-10 12:45 ` Ivo van Doorn
2009-01-10 19:38 ` [PATCH] rt2400,rt2500: init led_qual for LED_MODE_DEFAULT Andrew Price
2009-01-10 23:26 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).