From: "John W. Linville" <linville@tuxdriver.com>
To: darklight <darklight.xdarklight@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: ignore the return value of ath5k_hw_noise_floor_calibration
Date: Tue, 13 Jan 2009 14:43:25 -0500 [thread overview]
Message-ID: <20090113194325.GE3623@tuxdriver.com> (raw)
In-Reply-To: <888a464d0901091721l6657e755vbfe5bae0367f6413@mail.gmail.com>
On Sat, Jan 10, 2009 at 02:21:44AM +0100, darklight wrote:
> hi,
>
> some weeks ago Felix Fietkau posted a patch for the "ath5k phy0:
> unsupported jumbo" warnings (see here:
> http://article.gmane.org/gmane.linux.kernel.wireless.general/23430 )
> I just had the same problem - after applying Felix' patch the warnings
> went down from 50-100 per day to 5.
>
> as a quick note: I did not just apply this patch, instead I replaced
> Linus' upstream wireless stack with the one from wireless-testing
> (using kernel version 2.6.28)
>
> I hope Felix' patch can get into Linus' kernel (mainline) so other
> users can profit from this
It is in Linus' kernel right now:
commit 8b0162a3dc5c30e862b7a73da29e32de3170f5e4
Author: Felix Fietkau <nbd@openwrt.org>
Date: Mon Nov 3 11:27:38 2008 +0100
ath5k: ignore the return value of ath5k_hw_noise_floor_calibration
Noise floor calibration occasionally fails on Atheros hardware.
This is not fatal and can happen if there's simply too much
noise on the air. Ignoring the calibration error is the right
thing to do here, because when the error is ignored, the hardware
will still work, whereas if the error causes the driver to bail out
of a bigger configuration function and does not configure the tx
queues or the IMR (as is the case in reset.c), the hw no longer
works properly until the next reset.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Hth!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-01-13 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 1:21 [PATCH] ath5k: ignore the return value of ath5k_hw_noise_floor_calibration darklight
2009-01-10 23:15 ` Bob Copeland
2009-01-15 18:49 ` [stable] " Greg KH
2009-01-13 19:43 ` John W. Linville [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-03 10:27 Felix Fietkau
2008-11-03 19:27 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113194325.GE3623@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=darklight.xdarklight@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).