From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Michael Buesch <mb@bu3sch.de>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Warning in latest wireless-testing
Date: Wed, 14 Jan 2009 08:33:23 -0500 [thread overview]
Message-ID: <20090114133322.GA18634@tuxdriver.com> (raw)
In-Reply-To: <1231891570.28311.0.camel@johannes>
On Wed, Jan 14, 2009 at 01:06:10AM +0100, Johannes Berg wrote:
> On Tue, 2009-01-13 at 17:59 -0600, Larry Finger wrote:
> > In the latest pull from wireless testing, I get the following warni=
ng:
> >=20
> > CC [M] drivers/net/wireless/b43/main.o
> > drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_set_ke=
y=E2=80=99:
> > drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatc=
h
> > in conditional expression
>=20
> That looks like a merge error:
Yes, it is.
> b43dbg(wl, "%s hardware based encryption for keyidx: =
%d, "
> "mac: %pM\n",
> cmd =3D=3D SET_KEY ? "Using" : "Disabling", ke=
y->keyidx,
> sta ? sta->addr : "<group key>");
>=20
> It should be something like
>=20
> u8 bcast[ETH_ALEN] =3D {0xff,...}
>=20
> sta ? sta->addr : bcast
>=20
> there.
Yes, it should.
John
--=20
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-01-14 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 23:59 Warning in latest wireless-testing Larry Finger
2009-01-14 0:06 ` Johannes Berg
2009-01-14 13:33 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114133322.GA18634@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).