Re: [PATCH 07/13] cfg80211: only export disable flag on channel disablement

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Fri, Jan 16, 2009 at 01:23:47AM -0800, Johannes Berg wrote:
> On Thu, 2009-01-15 at 16:12 -0800, Luis R. Rodriguez wrote:
> > When a channel is disabled there is no need to stuff it
> > with more flags.
> 
> > -	u32 flags;
> > +	u32 flags, rule_flags;
> >  	u32 max_bandwidth = 0;
> >  	const struct ieee80211_reg_rule *reg_rule = NULL;
> >  	const struct ieee80211_power_rule *power_rule = NULL;
> > @@ -913,15 +913,19 @@ static void handle_channel(struct wiphy *wiphy, enum ieee80211_band band,
> >  					"Country IE\n",
> >  					chan->center_freq, wiphy_name(wiphy));
> >  #endif
> > -			flags |= IEEE80211_CHAN_DISABLED;
> > -			chan->flags = flags;
> > +			chan->flags = IEEE80211_CHAN_DISABLED;
> >  		}
> >  		return;
> >  	}
> >  
> >  	power_rule = &reg_rule->power_rule;
> >  
> > -	chan->flags = flags | map_regdom_flags(reg_rule->flags);
> > +	rule_flags = map_regdom_flags(reg_rule->flags);
> > +	if (flags & IEEE80211_CHAN_DISABLED)
> > +		chan->flags = IEEE80211_CHAN_DISABLED;
> > +	else
> > +		chan->flags = flags | rule_flags;
> 
> but why bother with more complicated code when adding a few more flags
> doesn't hurt?

I don't see these few lines as complicated really, but if you don't like them
that's fine. We can also fix this in userspace so that disable|radar|no-ibss
doesn't show up. I frankly think its pointless to keep them though.

  Luis