Re: [PATCH 03/13] cfg80211: add wiphy_apply_custom_regulatory()

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Fri, Jan 16, 2009 at 12:37:50PM -0800, Johannes Berg wrote:
> On Fri, 2009-01-16 at 08:36 -0800, Luis R. Rodriguez wrote:
> 
> > > Also, I don't think calling the notifier is
> > > appropriate since the driver just called this function.
> > 
> > Calling the notifier is why we want REGDOM_SET_BY_PROBE. We also technically
> > do not need to call the notifier unless we want to allow for tricks like the
> > one I am using in ath9k to condense the regulatory domains to 5 based on frequency
> > and to let a helper sort out the flags. Without this I believe we'd be forced to
> > use 12 full blown regds.
> 
> I just don't see why the driver couldn't be like this:
> 
> static void helper(...) {...}
> 
> static void ath9k_reg_notifier(...) {
> 	helper(...)
> }
> 
> static void ath9k_something(...) {
> 	apply_custom_regulatory(..)
> 	helper(..)
> }
> 
> so cfg80211 doesn't call back into it but it does it itself. It's
> usually deadlock prone if some called code calls back into the caller
> code.

Sure I'll do it this way then.

  Luis