linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alina Friedrichsen" <x-alina@gmx.net>
To: Jouni Malinen <j@w1.fi>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Fixed BSSID step 3: Don't merge with the same BSSID
Date: Sat, 17 Jan 2009 23:12:25 +0100	[thread overview]
Message-ID: <20090117221225.301920@gmx.net> (raw)
In-Reply-To: <20090108091055.GA7009@jm.kir.nu>

Hello Jouni!

> I agree that merge part (updating Beacon/ProbeRsp data) can be skippe=
d
> for same BSSID, but this change seems to break timesync by removing c=
all
> to local->ops->reset_tsf(). I don't think that that should be removed
> unconditionally.

I have looked in the Source of ath5k and ath9k. It seens to me that the=
 TSF sync is done in the low-level driver and/or the hardware directly.=
 So I see no reason to set it back to zero, if you have a dummy merge t=
o the same BSSID and channel. (E.g. caused by TSF overflows.) I think i=
t should only done if you change the network, so BSSID and/or channel i=
s deferent.

Any doubts?

Regards
Alina

--=20
Sensationsangebot verl=E4ngert: GMX FreeDSL - Telefonanschluss + DSL=20
f=FCr nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K1308T45=
69a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-01-17 22:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06  2:01 [PATCH] Fixed BSSID step 3: Don't merge with the same BSSID Alina Friedrichsen
2009-01-08  9:10 ` Jouni Malinen
2009-01-09 20:53   ` Alina Friedrichsen
2009-01-10  9:16     ` Jouni Malinen
2009-01-12  4:15       ` Alina Friedrichsen
2009-01-12 17:35         ` Jouni Malinen
2009-01-17  3:39       ` [PATCH] Fixed BSSID (timesync) Alina Friedrichsen
2009-01-17  3:51       ` Alina Friedrichsen
2009-01-17 22:12   ` Alina Friedrichsen [this message]
2009-01-20 15:10     ` [PATCH] Fixed BSSID step 3: Don't merge with the same BSSID Jouni Malinen
2009-01-20 18:56       ` Alina Friedrichsen
2009-01-21  8:45         ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090117221225.301920@gmx.net \
    --to=x-alina@gmx.net \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).