Re: [PATCH 08/13] cfg80211: save original values on regulatory hints

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Sun, Jan 18, 2009 at 12:47:29AM -0800, Johannes Berg wrote:
> On Fri, 2009-01-16 at 13:06 -0800, Luis R. Rodriguez wrote:
> 
> > Well in ath9k we want this, and orig_* stuff is used only for custom
> > regulatory domains. How would we install information on orig_* from
> > a regulatory_hint() on drivers if we have drivres which may or may not
> > want to save that information on orig_* parameters?
> 
> Not sure.

The answer was above, but lets see.

> > > We just need to have the driver set
> > > orig_flags rather than cfg80211, no?
> > 
> > Oh you mean in the reg_notifier() on REGDOM_SET_BY_DRIVER? Sure, that works
> > as well, if so desired.
> 
> Well, I wasn't intending for anything to _ever_ touch orig_flags at
> all... 

Just so you know the approach I started taking for v3 of this series
was to apply save the orig_* parameters if REGDOM_SET_BY_DRIVER and
the request->wiphy == wiphy. This works OK except if you have "US"
as your regulatory domain and you have OLD_REG set cfg80211 will have
already have called for a new regulatory domain update for "US" so
this is -EALREADY. Some changes are then required to inform drivers
through the reg_notifier() of this. This is where I was at now.

> I think you're hampered by not being able to simply request a
> regdomain from crda outside the normal "apply regdomain" flow, 

Well I have a few approaches already which have worked but I like to 
think we're looking for the most simple solution so its easier to
support this for other drivers as well.

> maybe we
> should think about that instead? Then ath9k could just request a
> regdomain from crda before it even registers its wiphy?

Are you suggesting we consider new API for drivers which want the
behaviour we want? That works for me too, but then again I'd be applying
the save orig_* stuff perhaps at the end of this new, say,
regulatory_hint_strict().

  Luis