From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 03/13] cfg80211: add wiphy_apply_custom_regulatory()
Date: Sun, 18 Jan 2009 07:31:34 -0800 [thread overview]
Message-ID: <20090118153134.GT29609@tesla> (raw)
In-Reply-To: <1232268557.3877.12.camel@johannes>
On Sun, Jan 18, 2009 at 12:49:17AM -0800, Johannes Berg wrote:
> On Sat, 2009-01-17 at 14:06 -0800, Luis R. Rodriguez wrote:
>
> > > > >> > +static int freq_reg_info(struct wiphy *wiphy, u32 center_freq, u32 *bandwidth,
> > > > >> > + const struct ieee80211_reg_rule **reg_rule)
> > > > >> > +{
> > > > >> > + return freq_reg_info_regd(wiphy, center_freq,
> > > > >> > + bandwidth, reg_rule, NULL);
> > > > >> > +}
> > > > >>
> > > > >> Are you not using this or am I just not seeing the user?
> > > > >
> > > > > Yeah -- good catch, its just cruft left over from my previous work.
> > > >
> > > > Actually freq_reg_info_regd() is used by handle_channel_custom(),
> > > > hence my comment on re-inventing the wheel. But yeah it used.
> > >
> > > Yeah but not freq_reg_info?
> >
> > That one is used by the reg_notifier() in ath9k to inspect the country IE
> > regulatory domain processed.
>
> ?? It's static and not exported, so how can ath9k use it?
Patch 04 in this series fixes that.
Luis
next prev parent reply other threads:[~2009-01-18 15:32 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 0:12 [PATCH 00/13] cfg80211/mac80211: fixes/enhancements for reg_notifier() Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 01/13] cfg80211: print correct intersected regulatory domain Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 02/13] cfg80211: add option for wiphys to disregard country IEs Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 03/13] cfg80211: add wiphy_apply_custom_regulatory() Luis R. Rodriguez
[not found] ` <1232064746-17134-5-git-send-email-lrodriguez@atheros.com>
2009-01-16 0:12 ` [PATCH 05/13] cfg80211: Fix sanity check on 5 GHz when processing country IE Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 06/13] cfg80211: process user requests only after previous user/driver/core requests Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 07/13] cfg80211: only export disable flag on channel disablement Luis R. Rodriguez
[not found] ` <1232064746-17134-9-git-send-email-lrodriguez@atheros.com>
2009-01-16 0:12 ` [PATCH 09/13] cfg80211: rename fw_handles_regulatory to custom_regulatory Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 10/13] cfg80211: remove check for last_request on ignore_reg_update() Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 11/13] cfg80211: move check for ignore_reg_update() on wiphy_update_regulatory() Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 12/13] mac80211: allow mac80211 drivers to get to struct ieee80211_hw from wiphy Luis R. Rodriguez
2009-01-16 0:12 ` [PATCH 13/13] cfg80211: Remove CONFIG_WIRELESS_OLD_REGULATORY Luis R. Rodriguez
2009-01-16 9:28 ` Johannes Berg
2009-01-16 15:14 ` John W. Linville
2009-01-16 9:27 ` [PATCH 12/13] mac80211: allow mac80211 drivers to get to struct ieee80211_hw from wiphy Johannes Berg
2009-01-16 9:27 ` [PATCH 11/13] cfg80211: move check for ignore_reg_update() on wiphy_update_regulatory() Johannes Berg
2009-01-16 9:26 ` [PATCH 10/13] cfg80211: remove check for last_request on ignore_reg_update() Johannes Berg
2009-01-16 16:27 ` Luis R. Rodriguez
2009-01-16 20:33 ` Johannes Berg
2009-01-16 21:02 ` Luis R. Rodriguez
2009-01-16 9:25 ` [PATCH 09/13] cfg80211: rename fw_handles_regulatory to custom_regulatory Johannes Berg
2009-01-16 9:25 ` [PATCH 08/13] cfg80211: save original values on regulatory hints Johannes Berg
2009-01-16 16:31 ` Luis R. Rodriguez
2009-01-16 20:34 ` Johannes Berg
2009-01-16 21:06 ` Luis R. Rodriguez
2009-01-18 8:47 ` Johannes Berg
2009-01-18 15:28 ` Luis R. Rodriguez
2009-01-18 17:12 ` Johannes Berg
2009-01-18 17:38 ` Luis R. Rodriguez
2009-01-16 9:23 ` [PATCH 07/13] cfg80211: only export disable flag on channel disablement Johannes Berg
2009-01-16 16:32 ` Luis R. Rodriguez
2009-01-16 20:35 ` Johannes Berg
2009-01-16 21:09 ` Luis R. Rodriguez
2009-01-18 8:48 ` Johannes Berg
2009-01-18 15:30 ` Luis R. Rodriguez
2009-01-18 17:13 ` Johannes Berg
2009-01-18 17:39 ` Luis R. Rodriguez
2009-01-16 9:22 ` [PATCH 06/13] cfg80211: process user requests only after previous user/driver/core requests Johannes Berg
2009-01-16 9:21 ` [PATCH 05/13] cfg80211: Fix sanity check on 5 GHz when processing country IE Johannes Berg
2009-01-16 9:20 ` [PATCH 03/13] cfg80211: add wiphy_apply_custom_regulatory() Johannes Berg
2009-01-16 16:36 ` Luis R. Rodriguez
2009-01-16 20:37 ` Johannes Berg
2009-01-16 21:12 ` Luis R. Rodriguez
2009-01-16 22:13 ` Luis R. Rodriguez
2009-01-17 9:30 ` Johannes Berg
2009-01-17 22:06 ` Luis R. Rodriguez
2009-01-18 8:49 ` Johannes Berg
2009-01-18 15:31 ` Luis R. Rodriguez [this message]
2009-01-18 17:15 ` Johannes Berg
2009-01-16 9:17 ` [PATCH 02/13] cfg80211: add option for wiphys to disregard country IEs Johannes Berg
2009-01-16 16:40 ` Luis R. Rodriguez
2009-01-16 20:38 ` Johannes Berg
2009-01-16 21:13 ` Luis R. Rodriguez
2009-01-16 9:16 ` [PATCH 01/13] cfg80211: print correct intersected regulatory domain Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118153134.GT29609@tesla \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).