From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.atheros.com ([12.36.123.2]:12867 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765352AbZARPcF (ORCPT ); Sun, 18 Jan 2009 10:32:05 -0500 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Sun, 18 Jan 2009 07:32:05 -0800 Date: Sun, 18 Jan 2009 07:31:34 -0800 From: "Luis R. Rodriguez" To: Johannes Berg CC: Luis Rodriguez , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH 03/13] cfg80211: add wiphy_apply_custom_regulatory() Message-ID: <20090118153134.GT29609@tesla> (sfid-20090118_163212_366969_AB04A35D) References: <1232064746-17134-1-git-send-email-lrodriguez@atheros.com> <1232064746-17134-2-git-send-email-lrodriguez@atheros.com> <1232064746-17134-3-git-send-email-lrodriguez@atheros.com> <1232064746-17134-4-git-send-email-lrodriguez@atheros.com> <1232097659.3854.20.camel@johannes> <20090116163646.GG29609@tesla> <43e72e890901161413n3fdd7031lfdd0a363941b697d@mail.gmail.com> <1232184649.3668.2.camel@johannes> <20090117220636.GO29609@tesla> <1232268557.3877.12.camel@johannes> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1232268557.3877.12.camel@johannes> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Jan 18, 2009 at 12:49:17AM -0800, Johannes Berg wrote: > On Sat, 2009-01-17 at 14:06 -0800, Luis R. Rodriguez wrote: > > > > > >> > +static int freq_reg_info(struct wiphy *wiphy, u32 center_freq, u32 *bandwidth, > > > > >> > + const struct ieee80211_reg_rule **reg_rule) > > > > >> > +{ > > > > >> > + return freq_reg_info_regd(wiphy, center_freq, > > > > >> > + bandwidth, reg_rule, NULL); > > > > >> > +} > > > > >> > > > > >> Are you not using this or am I just not seeing the user? > > > > > > > > > > Yeah -- good catch, its just cruft left over from my previous work. > > > > > > > > Actually freq_reg_info_regd() is used by handle_channel_custom(), > > > > hence my comment on re-inventing the wheel. But yeah it used. > > > > > > Yeah but not freq_reg_info? > > > > That one is used by the reg_notifier() in ath9k to inspect the country IE > > regulatory domain processed. > > ?? It's static and not exported, so how can ath9k use it? Patch 04 in this series fixes that. Luis