* [PATCH 1/2] iwl3945: fix some warnings when compiled without debug
@ 2009-01-19 8:55 Helmut Schaa
2009-01-19 10:09 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Helmut Schaa @ 2009-01-19 8:55 UTC (permalink / raw)
To: linville; +Cc: linux-wireless
=46ix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG.
drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98iwl39=
45_rx_reply_add_sta=E2=80=99:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused varia=
ble =E2=80=98pkt=E2=80=99
drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98iwl39=
45_rx_scan_results_notif=E2=80=99:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused varia=
ble =E2=80=98notif=E2=80=99
drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98iwl39=
45_rx_scan_complete_notif=E2=80=99:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused varia=
ble =E2=80=98scan_notif=E2=80=99
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/=
wireless/iwlwifi/iwl3945-base.c
index b437cac..15d36d8 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl_pri=
v *priv,
static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
struct iwl_rx_mem_buffer *rxb)
{
+ #ifdef CONFIG_IWLWIFI_DEBUG
struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
+ #endif=20
=20
IWL_DEBUG_RX("Received REPLY_ADD_STA: 0x%02X\n", pkt->u.status);
return;
@@ -2898,9 +2900,11 @@ static void iwl3945_rx_scan_start_notif(struct i=
wl_priv *priv,
static void iwl3945_rx_scan_results_notif(struct iwl_priv *priv,
struct iwl_rx_mem_buffer *rxb)
{
+ #ifdef CONFIG_IWLWIFI_DEBUG
struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
struct iwl_scanresults_notification *notif =3D
(struct iwl_scanresults_notification *)pkt->u.raw;
+ #endif
=20
IWL_DEBUG_SCAN("Scan ch.res: "
"%d [802.11%s] "
@@ -2923,8 +2927,10 @@ static void iwl3945_rx_scan_results_notif(struct=
iwl_priv *priv,
static void iwl3945_rx_scan_complete_notif(struct iwl_priv *priv,
struct iwl_rx_mem_buffer *rxb)
{
+ #ifdef CONFIG_IWLWIFI_DEBUG
struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
struct iwl_scancomplete_notification *scan_notif =3D (void *)pkt->u.r=
aw;
+ #endif
=20
IWL_DEBUG_SCAN("Scan complete: %d channels (TSF 0x%08X:%08X) - %d\n",
scan_notif->scanned_channels,
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] iwl3945: fix some warnings when compiled without debug
2009-01-19 8:55 [PATCH 1/2] iwl3945: fix some warnings when compiled without debug Helmut Schaa
@ 2009-01-19 10:09 ` Johannes Berg
2009-01-19 11:59 ` Helmut Schaa
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2009-01-19 10:09 UTC (permalink / raw)
To: Helmut Schaa; +Cc: linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
On Mon, 2009-01-19 at 09:55 +0100, Helmut Schaa wrote:
> Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG.
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_reply_add_sta’:
> drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused variable ‘pkt’
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_scan_results_notif’:
> drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused variable ‘notif’
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_scan_complete_notif’:
> drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused variable ‘scan_notif’
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index b437cac..15d36d8 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl_priv *priv,
> static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
> struct iwl_rx_mem_buffer *rxb)
> {
> + #ifdef CONFIG_IWLWIFI_DEBUG
> struct iwl_rx_packet *pkt = (void *)rxb->skb->data;
> + #endif
I for one would definitely prefer you didn't indent preprocessor
statements, but I don't care all that much about iwl3945.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] iwl3945: fix some warnings when compiled without debug
2009-01-19 10:09 ` Johannes Berg
@ 2009-01-19 11:59 ` Helmut Schaa
0 siblings, 0 replies; 3+ messages in thread
From: Helmut Schaa @ 2009-01-19 11:59 UTC (permalink / raw)
To: Johannes Berg; +Cc: linville, linux-wireless
Am Montag, 19. Januar 2009 schrieb Johannes Berg:
> On Mon, 2009-01-19 at 09:55 +0100, Helmut Schaa wrote:
> > Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG=
=2E
> >=20
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_reply_add_sta=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused v=
ariable =E2=80=98pkt=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_scan_results_notif=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused v=
ariable =E2=80=98notif=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_scan_complete_notif=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused v=
ariable =E2=80=98scan_notif=E2=80=99
> >=20
> > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > ---
> > diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/=
net/wireless/iwlwifi/iwl3945-base.c
> > index b437cac..15d36d8 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > @@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl=
_priv *priv,
> > static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
> > struct iwl_rx_mem_buffer *rxb)
> > {
> > + #ifdef CONFIG_IWLWIFI_DEBUG
> > struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
> > + #endif=20
>=20
> I for one would definitely prefer you didn't indent preprocessor
> statements, but I don't care all that much about iwl3945.
Indeed. My fault. I'll resend this one.
Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-19 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-19 8:55 [PATCH 1/2] iwl3945: fix some warnings when compiled without debug Helmut Schaa
2009-01-19 10:09 ` Johannes Berg
2009-01-19 11:59 ` Helmut Schaa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).