From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] iwl3945: fix some warnings when compiled without debug
Date: Mon, 19 Jan 2009 12:59:34 +0100 [thread overview]
Message-ID: <200901191259.35309.helmut.schaa@gmail.com> (raw)
In-Reply-To: <1232359746.3758.0.camel@johannes>
Am Montag, 19. Januar 2009 schrieb Johannes Berg:
> On Mon, 2009-01-19 at 09:55 +0100, Helmut Schaa wrote:
> > Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG=
=2E
> >=20
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_reply_add_sta=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused v=
ariable =E2=80=98pkt=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_scan_results_notif=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused v=
ariable =E2=80=98notif=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_scan_complete_notif=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused v=
ariable =E2=80=98scan_notif=E2=80=99
> >=20
> > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > ---
> > diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/=
net/wireless/iwlwifi/iwl3945-base.c
> > index b437cac..15d36d8 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > @@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl=
_priv *priv,
> > static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
> > struct iwl_rx_mem_buffer *rxb)
> > {
> > + #ifdef CONFIG_IWLWIFI_DEBUG
> > struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
> > + #endif=20
>=20
> I for one would definitely prefer you didn't indent preprocessor
> statements, but I don't care all that much about iwl3945.
Indeed. My fault. I'll resend this one.
Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-01-19 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 8:55 [PATCH 1/2] iwl3945: fix some warnings when compiled without debug Helmut Schaa
2009-01-19 10:09 ` Johannes Berg
2009-01-19 11:59 ` Helmut Schaa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901191259.35309.helmut.schaa@gmail.com \
--to=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).