Re: [stable] Failed Build of modules for 2.6.27.9-159

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Tue, Jan 20, 2009 at 12:05:15PM -0800, Greg KH wrote:
> On Tue, Jan 20, 2009 at 11:42:43AM -0800, Luis R. Rodriguez wrote:
> > On Mon, Jan 19, 2009 at 10:42:18PM -0800, Paul Hickey wrote:
> > > Hi Luis,
> > >
> > > 2.6.27.9-159.fc10.x86_64 is the kernel. I burned the distro right=
 from
> > > Fedora.
> >
> > I am =FCber-surprised to hear that FC10 2.6.27 kernels have added
> > pci_ioremap_bar() in their kernel header include/linux/pci.h. I
> > have verified this by checking:
> >
> > http://download.fedora.redhat.com/pub/fedora/linux/updates/10/x86_6=
4/kernel-devel-2.6.27.9-159.fc10.x86_64.rpm
> >
> > I have checked upstrea 2.6.27.9 and even 2.6.27.12 and they do not =
have this. This breaks
> > compatibility projects like compat-wireless :(
>=20
> compatibility projects should be checking for the absense or presence=
 of
> specific functions, not triggering off of kernel release numbers :)

How can I do that? #ifdef no worky on static inlines, for example.

BTW are you saying the above practice of adding new stuff to headers
is OK too? I wish it wasn't...

> > > Also, the ForceXPA might not be a problem, but it makes and logs =
its
> > > attempts 4X per minute. It may not be much of an impact on the CP=
U, but
> > > is it necessary? Plus the message log gets really long really fas=
t.
> >
> > Good point, hopefully this is enough of an argument to make the pat=
ch
> > go into 2.6.27. The patch is already in for >=3D 2.6.28.
> >
> > Greg -- there is an annoying message that gets printed very often
> > when new Atheros 11n cards are used, this is printed upon hw reset
> > which occurs on channel changes (scans) and as such happens quite
> > often. The message was moved to print only when "EEPROM debugging"
> > was enaabled through upstream commit f1dc56003b23d2d5bb5a756de6b163=
3a76c9e697.
> > Unfortunately this commit is pretty large as it refactored hw.c int=
o
> > separate files. Below is a small one line patch that changes this. =
Please
> > let me know if this is OK for 2.6.27.x
>=20
> Looks good to me, I'll queue it up for the next .27 release.

Awesome thanks.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html