Re: [stable] Failed Build of modules for 2.6.27.9-159

[Greg KH <greg@kroah.com>]

On Tue, Jan 20, 2009 at 12:13:16PM -0800, Luis R. Rodriguez wrote:
> On Tue, Jan 20, 2009 at 12:05:15PM -0800, Greg KH wrote:
> > On Tue, Jan 20, 2009 at 11:42:43AM -0800, Luis R. Rodriguez wrote:
> > > On Mon, Jan 19, 2009 at 10:42:18PM -0800, Paul Hickey wrote:
> > > > Hi Luis,
> > > >
> > > > 2.6.27.9-159.fc10.x86_64 is the kernel. I burned the distro rig=
ht from
> > > > Fedora.
> > >
> > > I am =FCber-surprised to hear that FC10 2.6.27 kernels have added
> > > pci_ioremap_bar() in their kernel header include/linux/pci.h. I
> > > have verified this by checking:
> > >
> > > http://download.fedora.redhat.com/pub/fedora/linux/updates/10/x86=
_64/kernel-devel-2.6.27.9-159.fc10.x86_64.rpm
> > >
> > > I have checked upstrea 2.6.27.9 and even 2.6.27.12 and they do no=
t have this. This breaks
> > > compatibility projects like compat-wireless :(
> >=20
> > compatibility projects should be checking for the absense or presen=
ce of
> > specific functions, not triggering off of kernel release numbers :)
>=20
> How can I do that? #ifdef no worky on static inlines, for example.

You can automatically test if the feature is there, right?  If so, then
set your own #define for your compatiblity wrappers.

> BTW are you saying the above practice of adding new stuff to headers
> is OK too? I wish it wasn't...

Sure it's ok, distros can do whatever they want in their kernels, are
you telling them that they are now not allowed to do that?  :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html