From: Kalle Valo <kalle.valo@nokia.com>
To: johannes@sipsolutions.net, vivek.natraj@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: [RFC PATCH v2 0/2] mac80211: ps-poll implementation
Date: Thu, 22 Jan 2009 13:45:32 +0200 [thread overview]
Message-ID: <20090122114240.31443.18218.stgit@tikku> (raw)
Here's my suggestion for how to implement ps-poll in mac80211. Also
this fixes the case when dynamic_ps_timeout is zero.
I decided to use ps-polling when dynamic_ps_timeout is zero. If
userspace sets timeout to zero, it means that it's ready to sacrifice
throughput over power consumption. But in case there throughput is
more, userspace can set timeout to a non-zero value and null frame
wakeup is used instead, throughput is higher but power consumption
also increases.
Most probably this patchset breaks ath9k multicast handling. I
recommend ath9k to try do multicast tim bit handling in hardware, I
would really assume that to be possible. But if that's really
impossible, then it can be done in the driver. But having support for
waking up multicast tim bits in mac80211 is unreliable and complicated
the implementation, I just recommend dropping it.
Open question is that should power save be disabled whenever mac80211
is ps-polling the frames. For example, p54/stlc45xx does not require to
disable power save in that case, it just stays awake long enough to
receive the data frame from the AP. So I did not disable power save
mode in this case, but I would like to hear comments what other
hardware needs.
v2:
o RX_CONTINUE after sending ps-poll frame in ieee80211_rx_h_check_more_data()
o remove leftover debug printk
o use ps-poll only when dynamic_ps_timeout is zero, otherwise null frame
wakeup is used
---
Kalle Valo (2):
mac80211: use ps-poll when dynamic power save mode is disabled
mac80211: remove multicast check from check_tim()
net/mac80211/ieee80211_i.h | 3 ++
net/mac80211/mlme.c | 69 +++++++++++++++++++++++++++++++++++++-------
net/mac80211/rx.c | 34 ++++++++++++++++++++++
3 files changed, 95 insertions(+), 11 deletions(-)
next reply other threads:[~2009-01-22 11:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 11:45 Kalle Valo [this message]
2009-01-22 11:45 ` [RFC PATCH v2 1/2] mac80211: remove multicast check from check_tim() Kalle Valo
2009-01-28 14:59 ` Vivek Natarajan
2009-01-28 16:06 ` Kalle Valo
2009-01-22 11:45 ` [RFC PATCH v2 2/2] mac80211: use ps-poll when dynamic power save mode is disabled Kalle Valo
2009-01-22 17:02 ` Johannes Berg
2009-01-28 16:49 ` Kalle Valo
2009-01-28 18:52 ` Johannes Berg
2009-01-29 18:15 ` Kalle Valo
2009-01-29 18:32 ` Johannes Berg
2009-01-29 20:19 ` Kalle Valo
2009-01-23 23:28 ` Tomas Winkler
2009-01-28 8:39 ` Kalle Valo
2009-01-28 11:46 ` Tomas Winkler
2009-01-28 12:33 ` Kalle Valo
2009-01-28 13:00 ` Johannes Berg
2009-01-28 13:26 ` Tomas Winkler
2009-01-28 13:36 ` Johannes Berg
2009-01-22 13:00 ` [RFC PATCH v2 0/2] mac80211: ps-poll implementation Johannes Berg
2009-01-23 9:31 ` Kalle Valo
2009-01-23 22:11 ` Johannes Berg
2009-01-28 16:40 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2009-01-11 18:54 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122114240.31443.18218.stgit@tikku \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).