From: Helmut Schaa <helmut.schaa@googlemail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] iwl3945: Remove unused variables
Date: Thu, 22 Jan 2009 11:44:27 +0100 [thread overview]
Message-ID: <200901221144.27380.helmut.schaa@gmail.com> (raw)
In-Reply-To: <20090121192329.GB14710@tuxdriver.com>
Am Mittwoch, 21. Januar 2009 schrieb John W. Linville:
> On Mon, Jan 19, 2009 at 09:55:32AM +0100, Helmut Schaa wrote:
> > Fix the following warnings in iwl-3945-rs.c by removing unused vari=
ables.
> >=20
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iw=
l3945_rate_scale_flush_windows=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:186: warning: unused var=
iable =E2=80=98priv=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iw=
l3945_bg_rate_scale_flush=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:219: warning: unused var=
iable =E2=80=98priv=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iw=
l3945_collect_tx_data=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: warning: unused var=
iable =E2=80=98priv=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98rs=
_free_sta=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: warning: unused var=
iable =E2=80=98priv=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iw=
l3945_get_adjacent_rate=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:559: warning: unused var=
iable =E2=80=98priv=E2=80=99
> >=20
> > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
>=20
> With this applied, I get these:
>=20
> CC [M] drivers/net/wireless/iwlwifi/iwl-3945-rs.o
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iwl3=
945_rate_scale_flush_windows=E2=80=99:
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: =E2=80=98priv=E2=
=80=99 undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: (Each undeclar=
ed identifier is reported only once
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: for each funct=
ion it appears in.)
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iwl3=
945_bg_rate_scale_flush=E2=80=99:
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:222: error: =E2=80=98priv=E2=
=80=99 undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iwl3=
945_collect_tx_data=E2=80=99:
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: error: =E2=80=98priv=E2=
=80=99 undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98rs_f=
ree_sta=E2=80=99:
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: error: =E2=80=98priv=E2=
=80=99 undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function =E2=80=98iwl3=
945_get_adjacent_rate=E2=80=99:
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:594: error: =E2=80=98priv=E2=
=80=99 undeclared (first use in this function)
> make[2]: *** [drivers/net/wireless/iwlwifi/iwl-3945-rs.o] Error 1
> make[1]: *** [drivers/net/wireless/iwlwifi] Error 2
> make: *** [drivers/net/wireless/] Error 2
>=20
> Dropping...
Ah, sorry for that. I compiled without CONFIG_IWL_DEBUG. Instead of rem=
oving
these lines they should be surrounded by an CONFIG_IWL_DEBUG check. I'l=
l send
that soon.
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-22 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 8:55 [PATCH 2/2] iwl3945: Remove unused variables Helmut Schaa
2009-01-19 13:06 ` samuel
2009-01-21 19:23 ` John W. Linville
2009-01-22 10:44 ` Helmut Schaa [this message]
2009-01-22 11:28 ` Tomas Winkler
2009-01-22 19:08 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901221144.27380.helmut.schaa@gmail.com \
--to=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).