From: "Bob Copeland" <me@bobcopeland.com>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: linville@tuxdriver.com, jirislaby@gmail.com,
lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH 3/6] ath5k: continue reset sequence if gain calibration fails
Date: Thu, 22 Jan 2009 13:28:01 -0500 [thread overview]
Message-ID: <20090122174721.M76206@bobcopeland.com> (raw)
In-Reply-To: <40f31dec0901220936n27736162vade7e7c53e35a490@mail.gmail.com>
On Thu, 22 Jan 2009 19:36:45 +0200, Nick Kossifidis wrote
> Again i've already fixed that on my local branch (i said i'll update
> reset code and i did, i just have to make some tests first), it's what
> both HALs do. Notice that if offset calibration has not completed, i/q
> calibration can't work (according to patent doc) and noise floor
> calibration always fails on some chips.
Fair enough, sorry for stepping on your toes :( This one can be dropped
too.
Point is taken, although if gain calibration does fail, can we do anything
about it other than log an error? Looping forever in reset() is probably
not a good idea.
OTOH, I'm pretty sure miscalibrated phy is responsible for all the
"unsupported jumbo" errors; I hexdumped some of those and they're all
just noise.
(Side note, any reason we call reset() from ath5k_config_interface?
We're not changing channels, just setting the bssid.)
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-01-22 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 13:44 [PATCH 3/6] ath5k: continue reset sequence if gain calibration fails Bob Copeland
2009-01-22 17:36 ` Nick Kossifidis
2009-01-22 18:28 ` Bob Copeland [this message]
2009-01-22 19:03 ` Nick Kossifidis
2009-01-22 20:06 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122174721.M76206@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).