Re: [PATCH 3/6] ath5k: continue reset sequence if gain calibration fails

["Bob Copeland" <me@bobcopeland.com>]

On Thu, 22 Jan 2009 21:03:17 +0200, Nick Kossifidis wrote
> > OTOH, I'm pretty sure miscalibrated phy is responsible for all the
> > "unsupported jumbo" errors; I hexdumped some of those and they're all
> > just noise.
> >
> 
> Don't we get a phy error interrupt ?  I haven't looked into this ;-(

I printk-ed rs.rs_status, it's 0, so AR5K_RXERR_PHY is unset.  

I think the jumbo flag is supposed to indicate the packet is larger
than the buffer size.  However, we have a buffer size of 2500 so that
shouldn't happen for standard frames.  I did check into whether there
was a corruption issue, like skb_tailroom was smaller than a full 
packet because of an skb reuse bug or something like that.  But no, 
all were > 2500 bytes (incl roundup for cache line).  That's when 
I did the unmap and a hexdump and saw they have no 802.11 headers or
anything of the sort.  Felix suggested we just drop the warning.

> > (Side note, any reason we call reset() from ath5k_config_interface?
> > We're not changing channels, just setting the bssid.)
> >
> 
> Hmm, i'll check that and come back to you, i think we have to
> re-initialize PCU but i'm not sure. Also if it's supposed to set the
> bssid on a virtual if, we also have to set bssid mask to allow all
> configured bssids for all vifs.

Cool, let me know.  Yeah, configure_interface() doesn't do anything
with the bssid mask (other than reloading it inside hw_set_associd);
in fact it's all-1s forever right now, it seems.

--  
Bob Copeland %% www.bobcopeland.com