Re: [RFC][RFT][PATCH] p54usb: rx refill revamp

[Christian Lamparter <chunkeey@web.de>]

On Thursday 22 January 2009 16:43:20 Artur Skawina wrote:
> Christian Lamparter wrote:
> > On Thursday 22 January 2009 00:22:16 Artur Skawina wrote:
> > +	if (unlikely(!priv->common.hw->workqueue)) {
> > +		/*
> > +		 * Huh? mac80211 isn't fully initialized yet?
> > +		 * Please check your system, something bad is going on.
> > +		 */
> > +		WARN_ON(1);
> 
> please do not add WARN_ON's unless you're actually interested in the
> stacktrace, In this case it's a usb completion, so in most cases the
> backtrace isn't very interesting, wouldn't a printk be enough?
> [i was hitting this when testing, and it took several seconds to 
> get all the data to the console]

Ahh, wait!

In fact we "should" call BUG_ON here, as mac80211 is not fully initialized at
this point and we might have accidently submitted a dataframe to the stack.
(Of course, this attempt by the device to send garbage to the stack is
caught by the common-code... so no oops here)

However, I wonder if the WARN_ON gets triggered under normal operation or not.
(Just in case, no it does not trigger with the ISL3887 chips)

Regards,
	Chr