From: Bob Copeland <me@bobcopeland.com>
To: Tulio Magno Quites Machado Filho <tuliom@gmail.com>
Cc: linville@tuxdriver.com, ath5k-devel@lists.ath5k.org,
linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: support LED's on emachines E510 notebok
Date: Sun, 25 Jan 2009 16:20:44 -0500 [thread overview]
Message-ID: <20090125212044.GA3592@hash.localnet> (raw)
In-Reply-To: <1232914461-19607-1-git-send-email-tuliom@gmail.com>
On Sun, Jan 25, 2009 at 09:14:21PM +0100, Tulio Magno Quites Machado Filho wrote:
> Add vendor ID for AMBIT and use it to set the ath5k LED gpio.
Thanks!
> #define PCI_VENDOR_ID_FOXCONN 0x105b
>
> +#define PCI_VENDOR_ID_AMBIT 0x1468
> +
Can you put the vendor id in order? The file is supposed to be
sorted by vendor id, then by device id in order to reduce merge
conflicts.
With that change, feel free to add my:
Acked-by: Bob Copeland <me@bobcopeland.com>
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-01-25 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 20:14 [PATCH] ath5k: support LED's on emachines E510 notebok Tulio Magno Quites Machado Filho
2009-01-25 21:20 ` Bob Copeland [this message]
2009-01-25 21:33 ` [ath5k-devel] " Tulio Magno Quites Machado Filho
2009-01-25 21:56 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090125212044.GA3592@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tuliom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).