linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: mcgrof@gmail.com, Sujith.Manoharan@atheros.com, tomasw@gmail.com
Subject: [RFC/RFT 3/7] mac80211: hardware should not deny going back to legacy
Date: Mon, 26 Jan 2009 19:47:43 +0100	[thread overview]
Message-ID: <20090126184925.080610122@sipsolutions.net> (raw)
In-Reply-To: 20090126184740.036240879@sipsolutions.net

Doing so would be an MLME protocol violation when the peer disabled
the aggregation session. Quick driver review indicates that there are
error codes passed all over the drivers but cannot ever be nonzero
except in error conditions that would indicate mac80211 bugs.

No real changes here, since no drivers currently can return -EBUSY.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/agg-tx.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- wireless-testing.orig/net/mac80211/agg-tx.c	2009-01-26 19:41:36.000000000 +0100
+++ wireless-testing/net/mac80211/agg-tx.c	2009-01-26 19:41:47.000000000 +0100
@@ -393,9 +393,8 @@ int ieee80211_stop_tx_ba_session(struct 
 		ret = local->ops->ampdu_action(hw, IEEE80211_AMPDU_TX_STOP,
 					       &sta->sta, tid, NULL);
 
-	/* case HW denied going back to legacy */
-	if (ret) {
-		WARN_ON(ret != -EBUSY);
+	/* HW shall not deny going back to legacy */
+	if (WARN_ON(ret)) {
 		*state = HT_AGG_STATE_OPERATIONAL;
 		if (hw->ampdu_queues)
 			ieee80211_wake_queue(hw, sta->tid_to_tx_q[tid]);

-- 


  parent reply	other threads:[~2009-01-26 18:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 18:47 [RFC/RFT 0/7] mac80211 aggregation cleanups/fixes Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 1/7] mac80211: remove stray aggregation debugfs definition Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 2/7] mac80211: restructure HT code Johannes Berg
2009-01-26 18:47 ` Johannes Berg [this message]
2009-01-26 18:47 ` [RFC/RFT 4/7] mac80211: document TX aggregation (and small cleanup) Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 5/7] mac80211: fix race in TX aggregation Johannes Berg
2009-01-27 10:38   ` Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 6/7] mac80211: fix RX aggregation timeouts Johannes Berg
2009-01-27 10:05   ` [RFC/RFT 6/7 v2] " Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 7/7] mac80211: fix aggregation timer lockups Johannes Berg
2009-01-27  9:41   ` Tomas Winkler
2009-01-27  9:52     ` Johannes Berg
2009-01-27 10:38   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090126184925.080610122@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).