From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: mcgrof@gmail.com, Sujith.Manoharan@atheros.com, tomasw@gmail.com
Subject: [RFC/RFT 6/7] mac80211: fix RX aggregation timeouts
Date: Mon, 26 Jan 2009 19:47:46 +0100 [thread overview]
Message-ID: <20090126184925.677935607@sipsolutions.net> (raw)
In-Reply-To: 20090126184740.036240879@sipsolutions.net
The values are in TUs (1.024ms), not ms.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/rx.c | 4 ++--
net/mac80211/sta_info.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--- wireless-testing.orig/net/mac80211/rx.c 2009-01-26 16:56:28.000000000 +0100
+++ wireless-testing/net/mac80211/rx.c 2009-01-26 16:56:46.000000000 +0100
@@ -1652,7 +1652,7 @@ ieee80211_rx_h_ctrl(struct ieee80211_rx_
/* reset session timer */
if (tid_agg_rx->timeout) {
unsigned long expires =
- jiffies + (tid_agg_rx->timeout / 1000) * HZ;
+ jiffies + (tid_agg_rx->timeout / 1024) * HZ;
mod_timer(&tid_agg_rx->session_timer, expires);
}
@@ -2393,7 +2393,7 @@ static u8 ieee80211_rx_reorder_ampdu(str
/* reset session timer */
if (tid_agg_rx->timeout) {
unsigned long expires =
- jiffies + (tid_agg_rx->timeout / 1000) * HZ;
+ jiffies + (tid_agg_rx->timeout / 1024) * HZ;
mod_timer(&tid_agg_rx->session_timer, expires);
}
--- wireless-testing.orig/net/mac80211/sta_info.h 2009-01-26 16:55:59.000000000 +0100
+++ wireless-testing/net/mac80211/sta_info.h 2009-01-26 16:56:10.000000000 +0100
@@ -88,7 +88,7 @@ struct tid_ampdu_tx {
* @stored_mpdu_num: number of MPDUs in reordering buffer
* @ssn: Starting Sequence Number expected to be aggregated.
* @buf_size: buffer size for incoming A-MPDUs
- * @timeout: reset timer value.
+ * @timeout: reset timer value (in TUs).
* @dialog_token: dialog token for aggregation session
*/
struct tid_ampdu_rx {
--
next prev parent reply other threads:[~2009-01-26 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 18:47 [RFC/RFT 0/7] mac80211 aggregation cleanups/fixes Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 1/7] mac80211: remove stray aggregation debugfs definition Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 2/7] mac80211: restructure HT code Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 3/7] mac80211: hardware should not deny going back to legacy Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 4/7] mac80211: document TX aggregation (and small cleanup) Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 5/7] mac80211: fix race in TX aggregation Johannes Berg
2009-01-27 10:38 ` Johannes Berg
2009-01-26 18:47 ` Johannes Berg [this message]
2009-01-27 10:05 ` [RFC/RFT 6/7 v2] mac80211: fix RX aggregation timeouts Johannes Berg
2009-01-26 18:47 ` [RFC/RFT 7/7] mac80211: fix aggregation timer lockups Johannes Berg
2009-01-27 9:41 ` Tomas Winkler
2009-01-27 9:52 ` Johannes Berg
2009-01-27 10:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126184925.677935607@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).