From: "John W. Linville" <linville@tuxdriver.com>
To: Alina Friedrichsen <x-alina@gmx.net>
Cc: Bob Copeland <bcopeland@gmail.com>,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Set TSF fix
Date: Tue, 27 Jan 2009 16:25:57 -0500 [thread overview]
Message-ID: <20090127212557.GC11849@tuxdriver.com> (raw)
In-Reply-To: <20090126140130.14450@gmx.net>
On Mon, Jan 26, 2009 at 03:01:30PM +0100, Alina Friedrichsen wrote:
> Hello!
>
> > > Either way, I think the changelog should back up the claim by
> > > _something_. Even if it's just "tested on device XXX, old way doesn't
> > > work, new way does" or "looked at legacy HAL code" or ...
> >
> > Agreed, "tested on..." would be good. I looked at the HAL and it
> > doesn't have a set tsf function, only reset.
>
> The old code does not work on:
> AR5418+AR2122 (ath9k)
> AR5416+AR2133 (ath9k)
>
> The new code is tested on:
> AR5418+AR2122 (ath9k)
> AR5416+AR2133 (ath9k)
> AR5001X+ (ath5k)
> AR5007EG (ath5k)
>
> The old code was taken from:
> https://dev.openwrt.org/browser/trunk/package/madwifi/patches/383-ibss_hostap.patch
> (by Sven-Ola Tuecke)
Could you resubmit this patch with some/all of the above information
incorporated into the changelog? I'm dropping the current version
(with limited changelog) just to avoid my own confusion.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-01-27 21:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 8:12 [PATCH] ath5k: Set TSF fix Alina Friedrichsen
2009-01-25 16:41 ` Bob Copeland
2009-01-25 16:45 ` Johannes Berg
2009-01-25 16:47 ` Bob Copeland
2009-01-26 14:01 ` Alina Friedrichsen
2009-01-27 21:25 ` John W. Linville [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-02 22:29 Alina Friedrichsen
2009-03-02 22:44 ` Bob Copeland
2009-03-02 23:02 ` Alina Friedrichsen
2009-03-02 23:31 ` Bob Copeland
2009-03-03 21:45 ` Alina Friedrichsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127212557.GC11849@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=bcopeland@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).