From: Bob Copeland <me@bobcopeland.com>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com,
nbd@openwrt.org
Subject: Re: [PATCH 4/5] ath5k: Update initvals
Date: Sat, 31 Jan 2009 19:43:49 -0500 [thread overview]
Message-ID: <20090201004349.GB17607@hash.localnet> (raw)
In-Reply-To: <20090131023007.GD3342@makis>
On Sat, Jan 31, 2009 at 04:30:07AM +0200, Nick Kossifidis wrote:
> * Update initvals to match legacy and Sam's HAL
>
> Signed-Off-by: Nick Kossifidis <mickflemm@gmail.com>
I spot checked some of these, this is the only thing I saw:
> - { AR5K_BEACON_CNT_5211, 0x00000000 }, /* change */
> + { AR5K_FRAME_CTL_QOSM, 0x000fc78f },
legacy-hal and Sam disagree on the top 12 bits (0xffffc78f vs
0x000fc78f), we have Sam's.
Rest looks good to me, feel free to add my Acked-by if you want.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-02-01 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 2:30 [PATCH 4/5] ath5k: Update initvals Nick Kossifidis
2009-02-01 0:43 ` Bob Copeland [this message]
2009-02-01 4:36 ` [ath5k-devel] " Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201004349.GB17607@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).