Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

[Bob Copeland <me@bobcopeland.com>]

On Tue, Feb 03, 2009 at 06:28:47PM +0200, Nick Kossifidis wrote:
> Nice catch ;-)
> 
> Another difference i remembered is that we now don't set the TPC
> register to 3f (until we fix the whole tx power stuff). I'll try to
> reproduce this with my ar2425 as it turns it also has problems.

And the winning hunk is:

        if (ah->ah_version != AR5K_AR5210) {
                ath5k_hw_reg_write(ah, 0xffffffff, AR5K_PISR);
-               /* If we later allow tuning for this, store into sc structure */
-               data = AR5K_TUNE_RSSI_THRES |
-                       AR5K_TUNE_BMISS_THRES << AR5K_RSSI_THR_BMISS_S;
-               ath5k_hw_reg_write(ah, data, AR5K_RSSI_THR);
        }

(hmm, bmiss threshold, should've seen that before...)  

With that reverted from the rest of the patchset, I no longer get the
interrupt storm.  I do seem to get an occasional lockup at association
time, but I haven't caught an oops for that yet.  It could be unrelated.

-- 
Bob Copeland %% www.bobcopeland.com