Re: at76_usb development

[Oliver Neukum <oliver@neukum.org>]

Am Wednesday 04 February 2009 16:48:11 schrieb Kalle Valo:
> > AFAIK you should be sending patches to Greg against the version in
> > drivers/staging. =A0Kalle may want to be copied.
>=20
> Yes, please cc also me. I try to keep up-to-date what's happening wit=
h
> at76-usb so that the same fixes will be fixed in at76c50x-usb as well=
=2E

Here is what I found with at76-usb as it is in the current kernel:

 static int at76_wait_completion(struct at76_priv *priv, int cmd)
 {
        int status =3D 0;

        unsigned long timeout =3D jiffies + CMD_COMPLETION_TIMEOUT;

        do {

This can go wrong in a preemptible kernel. You have no guarantee the fu=
ll
timeout is granted.

@@ -1631,7 +1633,7 @@ static void at76_rx_tasklet(unsigned long param)
        buf =3D (struct at76_rx_buffer *)priv->rx_skb->data;

        if (urb->status !=3D 0) {
-               if (urb->status !=3D -ENOENT && urb->status !=3D -ECONN=
RESET)
+               if (urb->status !=3D -ENOENT && urb->status !=3D -ECONN=
RESET && urb->status !=3D -ESHUTDOWN)

Should also check for ESHUTDOWN, also in at76_mac80211_tx_callback()

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html